-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the ability to store the PDF reports into the filesystem #6495
Closed
Desvelao
wants to merge
13
commits into
4.9.0
from
enhancement/6487-remove-ability-store-pdf-reports-filesystem
Closed
Remove the ability to store the PDF reports into the filesystem #6495
Desvelao
wants to merge
13
commits into
4.9.0
from
enhancement/6487-remove-ability-store-pdf-reports-filesystem
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client instead of storing into the filesystem of the backend - Generation of PDF reports downloads the file to the client instead of storing into the filesystem of the backend - Refactor the Printer.print service to use a Buffer - Create a frontend service to save the file from the API response - Refactor the ReportingService to use the new generic service to save the file from the response - Adapt the endpoints that generate reports to return the file - POST /reports/modules/{moduleID} - POST /reports/groups/{groupID} - POST /reports/agents/{agentID} - POST /reports/agents/{agentID}/inventory
- Remove reporting application - Remove render components files
…F reports files - Remove API endpoints related to the management of PDF reports files - GET /reports - GET /reports/{name} - DELETE /reports
…ort file is valid
- Replace taking screenshot of visualuzations in startVis2Png method - Communicate dashboard with the Generate report button though Redux - Create reducer - Create action creator - Adapt the Generate report button - Remove disabledReport property comming from old dashboard rendering - Refactor the method to add the visualizations to the PDF report in the Printer service
6 tasks
6 tasks
…o enhancement/6487-remove-ability-store-pdf-reports-filesystem
- Remove service to migrate the direcotry name of the PDF reports stored in the filesystem - Remove constants related to PDF report paths
Desvelao
changed the title
Remove the ablity to store the PDF reports into the filesystem
Remove the ability to store the PDF reports into the filesystem
Mar 25, 2024
We will close this pull request due to this feature needs to be discussed and moved to a major version because it is a breaking change. |
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the ability to store the PDF reports in the filesystem of the plugin host.
Changes:
Warnings:
Issues Resolved
#6487
Evidence
[Provide screenshots or videos to prove this PR solves the issues]
Test
[Provide instructions to test this PR]
Check List
yarn test:jest