-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement embeddable dashboard on PCI DSS #6504
Implement embeddable dashboard on PCI DSS #6504
Conversation
…o feat/6502-implement-embeddable-dashboard-on-pci-dss
|
|
|
…o feat/6502-implement-embeddable-dashboard-on-pci-dss
…o feat/6502-implement-embeddable-dashboard-on-pci-dss
…o feat/6502-implement-embeddable-dashboard-on-pci-dss
Test 🔴When the user unpins the agent, the agent is not removed from the url. Grabacion.2024-04-30.110838.mp4 |
…o feat/6502-implement-embeddable-dashboard-on-pci-dss
CR 🟢Test 🟡Dashboard
DetailsWhen the user unpins the agent, the agent is not removed from the url. The error is not responsibility of the PR. unpin-agent.webm
Detailsfilter-interaction.webm
ControlsGo to PCI DSS > Controls
Detailsleft-filters.webm
Detailsflyout.webm🟡 When the flyout is opened, the query is repeated. The error is not responsibility of the PR.
DetailsDashboard linkdashboard.webmEvents linkevents.webm
DetailsAgentagent.webmRulerule.webm |
…o feat/6502-implement-embeddable-dashboard-on-pci-dss
@lucianogorza , this toast appears due the old visualizations related to the PCI DSS were removed from the backend side and in the development branch, there is logic related to the old dashboard. When we remove this logic, the toast should not appear. Related image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When the user unpins the agent, the agent is not removed from the url.
- In
Controls
Tab, when the flyout is opened, the query is repeated
Those errors are not responsibility of this PR.
Details in comment #6504 (comment)
This is happening in other modules too and it should be related to the button to unpin the agent. Other co-workers are experiencing this problem and this should not be a reason to block the pull request
The repeated request is happening too on |
…lyout of Controls tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
…o feat/6502-implement-embeddable-dashboard-on-pci-dss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This pull request replaces the
Dashboard
tab and adapts thePanels
tab on PCI DSS applicationIssues Resolved
#6502
Evidence
Test
Go to PCI DSS > Dashboard:
Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
The visualizations have to be updated according to the filters applied in the searchbar.
The visualizations have to be updated when a search is performed in the searchbar.
If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
If there is SampleData, the corresponding SampleData message must appear.
If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Check filter behavior with respect to hide alerts, allow agents and filter order.
Go to PCI DSS > Controls
Check the requirements filters on the on the left side filters the requirements on the right side
Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.
In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement
The link on the flyout table should redirect to Endpoint Summary and Rules respectively
Check List
yarn test:jest