Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement embeddable dashboard on GDPR #6506

Merged
merged 21 commits into from
May 13, 2024

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Mar 13, 2024

Description

This pull request replaces the Dashboard and adapts the Controls tab on the GDPR application.

Other changes:

  • Fix repeated request on Regulatory compliance > Controls > flyout and MITRE ATT&CK > Framework > flyout

Issues Resolved

#6505

Evidence

image
image
image

Test

Go to GDPR > Dashboard:

Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
The visualizations have to be updated according to the filters applied in the searchbar.
The visualizations have to be updated when a search is performed in the searchbar.
If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
If there is SampleData, the corresponding SampleData message must appear.
If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Check filter behavior with respect to hide alerts, allow agents and filter order.

Go to GDPR > Controls
Check the requirements filters on the on the left side filters the requirements on the right side
Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.
In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement
The link on the flyout table should redirect to Endpoint Summary and Rules respectively

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Mar 13, 2024
@Desvelao Desvelao linked an issue Mar 13, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.37% ( 397 / 875 )
Branches 41.31% ( 157 / 380 )
Functions 43.83% ( 135 / 308 )
Lines 45.61% ( 395 / 866 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 10.8% ( 3751 / 34716 )
Branches 7.27% ( 1653 / 22731 )
Functions 10.5% ( 870 / 8282 )
Lines 10.95% ( 3645 / 33273 )

@Desvelao Desvelao marked this pull request as ready for review May 8, 2024 07:56
@Desvelao
Copy link
Member Author

Desvelao commented May 8, 2024

I found repeated filters on the discover table of Controls > flyout. This is happening in all the apps related to regulatory compliance and MITRE ATT&CK.

image

This should not be a reason to block the pull request. We will review this problem later.

@lucianogorza lucianogorza self-requested a review May 9, 2024 14:57
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ⚫

Test ⚫

Dashboard

  • Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
Details
  • The visualizations have to be updated according to the filters applied in the searchbar.
Details
  • The visualizations have to be updated when a search is performed in the searchbar.
Details
  • If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
Details
  • If there is SampleData, the corresponding SampleData message must appear.
Details
  • If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Details
  • Check filter behavior with respect to hide alerts, allow agents and filter order.
Details

Hide manager alerts: false

Hide manager alerts: true

Controls

Go to PCI DSS > Controls

  • Check the requirements filters on the on the left side filters the requirements on the right side
Details
  • Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.
Details

🟡 When the flyout is opened, the query is repeated. The error is not responsibility of the PR.

  • In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement
Details

Dashboard link

Events link

  • The link on the flyout table should redirect to Endpoint Summary and Rules respectively
Details

Agent

Rule

@JuanGarriuz JuanGarriuz self-requested a review May 10, 2024 10:38
…o feat/6505-implement-embeddable-dashboard-on-gdpr
@JuanGarriuz
Copy link
Member

Test 🟢

Dashboard

Grabacion.2024-05-10.135552.mp4

Controls

Grabacion.2024-05-10.135552.mp4

JuanGarriuz
JuanGarriuz previously approved these changes May 10, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@asteriscos
Copy link
Member

asteriscos commented May 13, 2024

CR 🟢

Test 🟢

Dashboard

🟢 Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.

Details

Peek 2024-05-13 12-49

🟢 The visualizations have to be updated according to the filters applied in the searchbar.

Details

Peek 2024-05-13 12-50

🟢 The visualizations have to be updated when a search is performed in the searchbar.

Details

Peek 2024-05-13 12-52

🟢 If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.

Details

image

🟢 If there is SampleData, the corresponding SampleData message must appear.

Details

image

🟢 If an agent is pinned, the views must be updated and changed to the agent view, if applicable.

Details

Peek 2024-05-13 12-53

🟢 Check filter behavior with respect to hide alerts, allow agents and filter order.

Details

Hide manager alerts: false

image

Hide manager alerts: true

image

Controls

Go to PCI DSS > Controls

🟢 Check the requirements filters on the on the left side filters the requirements on the right side

Details

image

🟢 Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.

Details

image

🟢 In the details flyout click on the show on dashboard and events links, they should display these tabs with a filter related to the selected requirement

Details

Dashboard link

Peek 2024-05-13 13-06

Events link

Peek 2024-05-13 13-06

🟢 The link on the flyout table should redirect to Endpoint Summary and Rules respectively

Details

Agent

Peek 2024-05-13 13-08

Rule

Peek 2024-05-13 13-09

@asteriscos asteriscos merged commit 5a3ac2a into 4.9.0 May 13, 2024
1 check passed
@asteriscos asteriscos deleted the feat/6505-implement-embeddable-dashboard-on-gdpr branch May 13, 2024 11:11
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Implement embeddable dashboard on GDPR module
4 participants