-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement embeddable dashboard on GDPR #6506
Implement embeddable dashboard on GDPR #6506
Conversation
…o feat/6505-implement-embeddable-dashboard-on-gdpr
|
|
|
…o feat/6505-implement-embeddable-dashboard-on-gdpr
…o feat/6505-implement-embeddable-dashboard-on-gdpr
…o feat/6505-implement-embeddable-dashboard-on-gdpr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ⚫
Test ⚫
Dashboard
- Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
Details
- The visualizations have to be updated according to the filters applied in the searchbar.
Details
- The visualizations have to be updated when a search is performed in the searchbar.
Details
- If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
Details
- If there is SampleData, the corresponding SampleData message must appear.
Details
- If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Details
- Check filter behavior with respect to hide alerts, allow agents and filter order.
Details
Hide manager alerts: false
Hide manager alerts: true
Controls
Go to PCI DSS > Controls
- Check the requirements filters on the on the left side filters the requirements on the right side
Details
- Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.
Details
🟡 When the flyout is opened, the query is repeated. The error is not responsibility of the PR.
- In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement
Details
Dashboard link
Events link
- The link on the flyout table should redirect to Endpoint Summary and Rules respectively
Details
Agent
Rule
…o feat/6505-implement-embeddable-dashboard-on-gdpr
Test 🟢DashboardGrabacion.2024-05-10.135552.mp4ControlsGrabacion.2024-05-10.135552.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
CR 🟢Test 🟢Dashboard🟢 Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking. 🟢 The visualizations have to be updated according to the filters applied in the searchbar. 🟢 The visualizations have to be updated when a search is performed in the searchbar. 🟢 If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered. 🟢 If there is SampleData, the corresponding SampleData message must appear. 🟢 If an agent is pinned, the views must be updated and changed to the agent view, if applicable. 🟢 Check filter behavior with respect to hide alerts, allow agents and filter order. ControlsGo to PCI DSS > Controls 🟢 Check the requirements filters on the on the left side filters the requirements on the right side 🟢 Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled. 🟢 In the details flyout click on the show on dashboard and events links, they should display these tabs with a filter related to the selected requirement 🟢 The link on the flyout table should redirect to Endpoint Summary and Rules respectively |
Description
This pull request replaces the
Dashboard
and adapts theControls
tab on the GDPR application.Other changes:
Issues Resolved
#6505
Evidence
Test
Go to GDPR > Dashboard:
Each visualization, if applicable, must have interaction so that it adds the corresponding filter(s) upon clicking.
The visualizations have to be updated according to the filters applied in the searchbar.
The visualizations have to be updated when a search is performed in the searchbar.
If there are no results, the corresponding message must appear that there are no results and the visualizations should not be rendered.
If there is SampleData, the corresponding SampleData message must appear.
If an agent is pinned, the views must be updated and changed to the agent view, if applicable.
Check filter behavior with respect to hide alerts, allow agents and filter order.
Go to GDPR > Controls
Check the requirements filters on the on the left side filters the requirements on the right side
Click on the requirement to open the flyout and interact with the search bar and links, they should work as expected. The search should take into account optionally the allowed agents and the hide manager alerts plugin setting if enabled.
In the details flyout click on the show on dashboard and events links, they should display this tabs with a filter related to the selected requirement
The link on the flyout table should redirect to Endpoint Summary and Rules respectively
Check List
yarn test:jest