-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement embeddable dashboard on Malware Detection module #6521
Implement embeddable dashboard on Malware Detection module #6521
Conversation
|
|
|
…ashboard-on-malware-detection-module
…ashboard-on-malware-detection-module
plugins/main/public/components/overview/malware-detection/dashboard/dashboard.tsx
Show resolved
Hide resolved
…ashboard-on-malware-detection-module
…ashboard-on-malware-detection-module
…ashboard-on-malware-detection-module
…ashboard-on-malware-detection-module
…ashboard-on-malware-detection-module
Test 🟡Global
Inconsistent data in Dashboard tableIn the Dashboard tab, the table shows only 4 records, while the Inventory tab has 357. Inconsistent chart and axis titles
Hide manager alerts: offHide manager alerts: on
The filters can't be removed when navigate from another page 🟢The filters can be removed after refresh the entire page 🟡Dashboard tab
With the term "windows" the Dashboard doesn't show any dataBut with "Windows" it does show results (case sensitive)
Events tab (Discover)Search bar
Histogram chart
Data grid
data-grid-features.webm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In the Dashboard tab, the table shows only 4 records, while the Inventory tab has 357.
- The fixed filters can be removed after refresh the entire page.
Details in comment #6521 (comment)
…ashboard-on-malware-detection-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR 🟢
Test 🟢
Consistent labels and chart types
The other warnings in the comment #6521 (comment) are not responsibilities of this PR.
TestGlobal
Dashboard tab
Events tab (Discover)Search bar
Histogram chart
Grabacion.2024-04-30.110838.mp4Data grid
Grabacion.2024-04-30.110838.mp4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
…ashboard-on-malware-detection-module
Description
This pull request replaces the
Dashboard
tab on Malware Detection application.Issues Resolved
#6520
Evidence
Test
Global
Enable/disable the hideManagerAlerts settings on App Settings
Dashboard tab
Events tab (Discover)
Search bar
add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)Histogram chart
Data grid
Check List
yarn test:jest