Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement embeddable dashboard on Malware Detection module #6521

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Mar 14, 2024

Description

This pull request replaces the Dashboard tab on Malware Detection application.

Issues Resolved

#6520

Evidence

image image

Test

Global

Test Chrome Firefox Safari
Check data results consistency between events and dashboard tab
Check the filters persist between the events and dashboard tab
Check the filters are cleaned when throwing in the events tab
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)
Check pinned agent filter on tabs
Check the request with hidden filters applied (allow agents, hide manager alerts)
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden)
  • Check data results consistency between events and dashboard tab
  • Check the filters persist between the events and dashboard tab
  • Check the filters are cleaned when throwing in the events tab
  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)
  • Check pinned agent filter on tabs
  • Check the request with hidden filters applied (allow agents, hide manager alerts)

Enable/disable the hideManagerAlerts settings on App Settings

Screenshot 2024-03-31 at 12 29 47
  • Check the fixed filter cannot be removed from the filter bar

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter
Add a filter through interaction with a visualization and check that the dashboard updates
Use the input and type an incorrect word to check if the no results message is shown
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results
  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter
  • Add a filter through interaction with a visualization and check that the dashboard updates
  • Use the input and type an incorrect word to check if the no results message is shown

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input
Apply filters using the search bar add filter feature
Apply filters using the date picker
Apply filters with no results (Check the No results match your search criteria message)
Use the saved queries feature (Check saved queries CRUD)
  • Apply filters using search bar input
  • Apply filters using the search bar add filter feature
  • Apply filters using the date picker
  • Apply filters with no results (Check the No results match your search criteria message)
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
  • Check histogram chart hits consistency
  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
  • Check all table header features (sort, show/hide columns, density, etc)
  • Check table pagination and rows per page
  • Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Mar 15, 2024
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.37% ( 397 / 875 )
Branches 41.31% ( 157 / 380 )
Functions 43.83% ( 135 / 308 )
Lines 45.61% ( 395 / 866 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 10.81% ( 3753 / 34708 )
Branches 7.27% ( 1653 / 22731 )
Functions 10.51% ( 870 / 8277 )
Lines 10.96% ( 3647 / 33265 )

@yenienserrano yenienserrano marked this pull request as ready for review April 19, 2024 12:51
@JuanGarriuz JuanGarriuz self-requested a review April 24, 2024 11:32
@lucianogorza lucianogorza self-requested a review April 29, 2024 15:24
@lucianogorza
Copy link
Contributor

lucianogorza commented Apr 29, 2024

Test 🟡

Global

Test Chrome Firefox Safari
Check data results consistency between events and dashboard tab 🟡
Check the filters persist between the events and dashboard tab 🟢
Check the filters are cleaned when throwing in the events tab 🟢
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢
Check pinned agent filter on tabs 🟢
Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden) 🟡
  • Check data results consistency between events and dashboard tab 🟡

Inconsistent data in Dashboard table

In the Dashboard tab, the table shows only 4 records, while the Inventory tab has 357.

image
image

Inconsistent chart and axis titles

image

  • Check the filters persist between the events and dashboard tab 🟢

image
image

  • Check the filters are cleaned when throwing in the events tab 🟢

image

  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢

Manager

image
image

Cluster

image
image

  • Check pinned agent filter on tabs 🟢

image
image

  • Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢

Enable/disable the hideManagerAlerts settings on App Settings

Hide manager alerts: off

image

Hide manager alerts: on

image

  • Check the fixed filter cannot be removed from the filter bar 🟡

The filters can't be removed when navigate from another page 🟢

image

The filters can be removed after refresh the entire page 🟡

image

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟡
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢
Add a filter through interaction with a visualization and check that the dashboard updates 🟢
Use the input and type an incorrect word to check if the no results message is shown 🟢
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟡

With the term "windows" the Dashboard doesn't show any data

image

But with "Windows" it does show results (case sensitive)

image

  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢

image

  • Add a filter through interaction with a visualization and check that the dashboard updates 🟢

image
image
image

  • Use the input and type an incorrect word to check if the no results message is shown 🟢

image

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
  • Apply filters using search bar input 🟢

image

  • Apply filters using the search bar add filter feature 🟢

image

  • Apply filters using the date picker 🟢

image

  • Apply filters with no results (Check the No results match your search criteria message) 🟢

image

  • Use the saved queries feature (Check saved queries CRUD) 🟢

image
image
image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
  • Check histogram chart hits consistency 🟢

image

  • Use chart options (three points: maximize, minimize, inspect) 🟢

Maximize

image

Inspect

image
image
image
image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
  • Check all table header features (sort, show/hide columns, density, etc) 🟢
data-grid-features.webm
  • Check table pagination and rows per page 🟢

image
image
image

  • Check document detail flyout 🟢

image

Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In the Dashboard tab, the table shows only 4 records, while the Inventory tab has 357.
  • The fixed filters can be removed after refresh the entire page.

Details in comment #6521 (comment)

Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

Consistent labels and chart types

image

The other warnings in the comment #6521 (comment) are not responsibilities of this PR.

@JuanGarriuz
Copy link
Member

Test

Global

Test Chrome Firefox Safari
Check data results consistency between events and dashboard tab 🟢
Check the filters persist between the events and dashboard tab 🟢
Check the filters are cleaned when throwing in the events tab 🟢
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢
Check pinned agent filter on tabs 🟢
Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden) 🟢
  • Check data results consistency between events and dashboard tab

image
image

  • Check the filters persist between the events and dashboard tab

image
image

  • Check the filters are cleaned when throwing in the events tab

image

  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)

image

  • Check pinned agent filter on tabs

image

  • Check the request with hidden filters applied (allow agents, hide manager alerts)

image
image

  • Check the fixed filter cannot be removed from the filter bar

image

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢
Add a filter through interaction with a visualization and check that the dashboard updates 🟢
Use the input and type an incorrect word to check if the no results message is shown 🟢
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results

image

  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter

image

  • Add a filter through interaction with a visualization and check that the dashboard updates

image
image

  • Use the input and type an incorrect word to check if the no results message is shown

image

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
  • Apply filters using search bar input

image

  • Apply filters using the search bar add filter feature

image

  • Apply filters using the date picker

image

  • Apply filters with no results (Check the No results match your search criteria message)

image

  • Use the saved queries feature (Check saved queries CRUD)

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
  • Check histogram chart hits consistency

image

  • Use chart options (three points: maximize, minimize, inspect)
Grabacion.2024-04-30.110838.mp4

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
  • Check all table header features (sort, show/hide columns, density, etc)
Grabacion.2024-04-30.110838.mp4
  • Check document detail flyout

image

Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@asteriscos asteriscos merged commit b8bfd00 into 4.9.0 May 2, 2024
1 check passed
@asteriscos asteriscos deleted the 6520-remove-discover-implement-embeddable-dashboard-on-malware-detection-module branch May 2, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Implement embeddable dashboard on Malware Detection module
4 participants