Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement embeddable dashboard on FIM module #6609

Merged

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Apr 19, 2024

Description

This pull request replaces the Dashboard tab on FIM application.

Issues Resolved

#6608

Evidence

image image image

Test

Global

Test Chrome Firefox Safari
Check data results consistency between Events and dashboard tab
Check the filters persist between the Events and dashboard tab
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)
Check pinned agent filter on tabs
Check the request with hidden filters applied (allow agents, hide manager alerts)
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden)
  • Check data results consistency between Events and dashboard tab
  • Check the filters persist between the Events and dashboard tab
  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)
  • Check pinned agent filter on tabs
  • Check the request with hidden filters applied (allow agents, hide manager alerts)

Enable/disable the hideManagerAlerts settings on App Settings

Screenshot 2024-03-31 at 12 29 47
  • Check the fixed filter cannot be removed from the filter bar

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter
Add a filter through interaction with a visualization and check that the dashboard updates
Use the input and type an incorrect word to check if the no results message is shown
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results
  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter
  • Add a filter through interaction with a visualization and check that the dashboard updates
  • Use the input and type an incorrect word to check if the no results message is shown

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input
Apply filters using the search bar add filter feature
Apply filters using the date picker
Apply filters with no results (Check the No results match your search criteria message)
Use the saved queries feature (Check saved queries CRUD)
  • Apply filters using search bar input
  • Apply filters using the search bar add filter feature
  • Apply filters using the date picker
  • Apply filters with no results (Check the No results match your search criteria message)
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
  • Check histogram chart hits consistency
  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
  • Check all table header features (sort, show/hide columns, density, etc)
  • Check table pagination and rows per page
  • Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Apr 19, 2024
@yenienserrano yenienserrano linked an issue Apr 19, 2024 that may be closed by this pull request
1 task
@yenienserrano yenienserrano marked this pull request as ready for review April 22, 2024 17:34
@Tostti
Copy link
Member

Tostti commented Apr 24, 2024

Test

Global

Test Chrome Firefox Safari
Check data results consistency between Events and dashboard tab 🟢
Check the filters persist between the Events and dashboard tab 🟢
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢
Check pinned agent filter on tabs 🟢
Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden) 🔴
  • Check data results consistency between Events and dashboard tab 🟢

Safari

image
image

  • Check the filters persist between the Events and dashboard tab 🟢

Safari

image
image

  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢

Safari
image
image
image
image

  • Check pinned agent filter on tabs 🟢

Safari
image
image

  • Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢

image

Enable the hideManagerAlerts settings on App Settings

image

image

  • Check the fixed filter cannot be removed from the filter bar 🔴 Solved in fa35cbe

Safari

image

If I just enter the page or reload it, I can remove the filters. However, after switching tabs, I cannot remove them anymore.

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢
Add a filter through interaction with a visualization and check that the dashboard updates 🟢
Use the input and type an incorrect word to check if the no results message is shown 🟢
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢

Safari
image

  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢

Safari
image

  • Add a filter through interaction with a visualization and check that the dashboard updates 🟢

Safari
image

  • Use the input and type an incorrect word to check if the no results message is shown 🟢

Safari
image

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
  • Apply filters using search bar input 🟢

Safari
image

  • Apply filters using the search bar add filter feature 🟢

Safari
image

  • Apply filters using the date picker 🟢

Safari
image

  • Apply filters with no results (Check the No results match your search criteria message) 🟢

Safari
image

  • Use the saved queries feature (Check saved queries CRUD) 🟢

Safari
image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
  • Check histogram chart hits consistency 🟢

Safari
image

  • Use chart options (three points: maximize, minimize, inspect) 🟢

Safari
image
image
image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟡
  • Check all table header features (sort, show/hide columns, density, etc) 🟢

Safari
image
image
image
image

  • Check table pagination and rows per page 🟢

Safari
image

  • Check document detail flyout 🟡

Safari
image

Thought It may be good to have also the JSON visualization in the flyout, as it has been requested previously for another module. It was added to Vulnerability Detector in #6590, the code may be reusable to also add it here.

@JuanGarriuz
Copy link
Member

JuanGarriuz commented Apr 25, 2024

Test

Global

Test Chrome Firefox Safari
Check data results consistency between Events and dashboard tab 🟢
Check the filters persist between the Events and dashboard tab 🟢
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢
Check pinned agent filter on tabs 🟢
Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden) 🟢
  • Check data results consistency between Events and dashboard tab 🟢

image
image

  • Check the filters persist between the Events and dashboard tab 🟢

image

  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢

image
image

  • Check pinned agent filter on tabs 🟢

image

  • Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢

image

  • Check the fixed filter cannot be removed from the filter bar 🟢

image

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢
Add a filter through interaction with a visualization and check that the dashboard updates 🟢
Use the input and type an incorrect word to check if the no results message is shown 🟢
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢

image

  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢

image

  • Add a filter through interaction with a visualization and check that the dashboard updates 🟢

image
image

  • Use the input and type an incorrect word to check if the no results message is shown 🟢

image

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
  • Apply filters using search bar input 🟢

image

  • Apply filters using the search bar add filter feature 🟢

image

  • Apply filters using the date picker 🟢

image

  • Apply filters with no results (Check the No results match your search criteria message) 🟢

image

  • Use the saved queries feature (Check saved queries CRUD) 🟢

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
  • Check histogram chart hits consistency 🟢

image
image

  • Use chart options (three points: maximize, minimize, inspect) 🟢

image
image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
  • Check all table header features (sort, show/hide columns, density, etc)
Grabacion.2024-04-26.094523.mp4
  • Check table pagination and rows per page 🟢

image
image

  • Check document detail flyout 🟢

image

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test ❌
CR ✅

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tostti Tostti merged commit 1651b75 into 4.9.0 Apr 26, 2024
1 check passed
@Tostti Tostti deleted the 6608-remove-discover-implement-embeddable-dashboard-on-fim-module branch April 26, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Implement embeddable dashboard on FIM module
3 participants