Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove agent AngularJS controller #6618

Merged
merged 15 commits into from
Apr 29, 2024

Conversation

lucianogorza
Copy link
Contributor

@lucianogorza lucianogorza commented Apr 24, 2024

Description

This pull request removes the agent AngularJS controller.

Issues Resolved

#6548

Evidence

Navigate from Endpoint Summary and change date range

initial-view.webm

Navigate with never connected agent

never-connected-agent.webm

Unpinned and change agent

unpinned-and-change-agent.webm

Update url when change tab

url-update.webm

Input new url

input-new-url.webm

Input url with not found agent

not-found-agent.webm

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Go to Server management -> Endpoint Summary and click on active agent. Ensure the agent view page is rendered correctly.
Go to Server management -> Endpoint Summary and click on never connected agent. It should render a message and a button to select an agent.
Select an agent from the previous step. Ensure the agent view page is rendered correctly.
On agent view page, click to unpinned agent. It should render a message and a button to select an agent.
On agent view page, click to select another agent. Ensure the agent view page is updated correctly.
On agent view page, click the Inventory data button. Ensure the Inventory data page and the url are updated correctly.
On agent view page, click the Stat button. Ensure the Stat page and the url are updated correctly.
On agent view page, click the Configuration button. Ensure the Configuration page and the url are updated correctly.
On agent view page, manually update the url with a non-unexistent agent. It should render an error.
On agent view page, change the date range. Ensure the agent view page is updated correctly.

Details

⚫ Go to Server management -> Endpoint Summary and click on active agent. Ensure the agent view page is rendered correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Go to Server management -> Endpoint Summary and click on never connected agent. It should render a message and a button to select an agent.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Select an agent from the previous step. Ensure the agent view page is rendered correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ On agent view page, click to unpinned agent. It should render a message and a button to select an agent.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ On agent view page, click to select another agent. Ensure the agent view page is updated correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ On agent view page, click the Inventory data button. Ensure the Inventory data page and the url are updated correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ On agent view page, click the Stat button. Ensure the Stat page and the url are updated correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ On agent view page, click the Configuration button. Ensure the Configuration page and the url are updated correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ On agent view page, manually update the url with a non-unexistent agent. It should render an error.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ On agent view page, change the date range. Ensure the agent view page is updated correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@lucianogorza lucianogorza changed the title Refactor angularjs agent controller Remove agent AngularJS controller Apr 24, 2024
@lucianogorza lucianogorza linked an issue Apr 24, 2024 that may be closed by this pull request
@lucianogorza lucianogorza self-assigned this Apr 24, 2024
@lucianogorza lucianogorza marked this pull request as ready for review April 25, 2024 16:21
@JuanGarriuz JuanGarriuz self-requested a review April 26, 2024 09:45
@JuanGarriuz
Copy link
Member

JuanGarriuz commented Apr 26, 2024

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Go to Server management -> Endpoint Summary and click on active agent. Ensure the agent view page is rendered correctly. 🟢
Go to Server management -> Endpoint Summary and click on never connected agent. It should render a message and a button to select an agent. 🟢
Select an agent from the previous step. Ensure the agent view page is rendered correctly. 🟢
On agent view page, click to unpinned agent. It should render a message and a button to select an agent. 🟢
On agent view page, click to select another agent. Ensure the agent view page is updated correctly. 🟢
On agent view page, click the Inventory data button. Ensure the Inventory data page and the url are updated correctly. 🟢
On agent view page, click the Stat button. Ensure the Stat page and the url are updated correctly. 🟢
On agent view page, click the Configuration button. Ensure the Configuration page and the url are updated correctly. 🟢
On agent view page, manually update the url with a non-unexistent agent. It should render an error. 🟢
On agent view page, change the date range. Ensure the agent view page is updated correctly. 🟢

Details

🟢 Go to Server management -> Endpoint Summary and click on active agent. Ensure the agent view page is rendered correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Go to Server management -> Endpoint Summary and click on never connected agent. It should render a message and a button to select an agent.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Select an agent from the previous step. Ensure the agent view page is rendered correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 On agent view page, click to unpinned agent. It should render a message and a button to select an agent.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 On agent view page, click to select another agent. Ensure the agent view page is updated correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 On agent view page, click the Inventory data button. Ensure the Inventory data page and the url are updated correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 On agent view page, click the Stat button. Ensure the Stat page and the url are updated correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 On agent view page, click the Configuration button. Ensure the Configuration page and the url are updated correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 On agent view page, manually update the url with a non-unexistent agent. It should render an error.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 On agent view page, change the date range. Ensure the agent view page is updated correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

JuanGarriuz
JuanGarriuz previously approved these changes Apr 26, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

JuanGarriuz
JuanGarriuz previously approved these changes Apr 26, 2024
@jbiset
Copy link
Member

jbiset commented Apr 26, 2024

CR: 🟢

Test UI: 🟢

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Test Chrome Firefox Safari
Go to Server management -> Endpoint Summary and click on active agent. Ensure the agent view page is rendered correctly. 🟢 🟢
Go to Server management -> Endpoint Summary and click on never connected agent. It should render a message and a button to select an agent. 🟢 🟢
Select an agent from the previous step. Ensure the agent view page is rendered correctly. 🟢 🟢
On agent view page, click to unpinned agent. It should render a message and a button to select an agent. 🟢 🟢
On agent view page, click to select another agent. Ensure the agent view page is updated correctly. 🟢 🟢
On agent view page, click the Inventory data button. Ensure the Inventory data page and the url are updated correctly. 🟢 🟢
On agent view page, click the Stat button. Ensure the Stat page and the url are updated correctly. 🟢 🟢
On agent view page, click the Configuration button. Ensure the Configuration page and the url are updated correctly. 🟢 🟢
On agent view page, manually update the url with a non-unexistent agent. It should render an error. 🟢 🟢
On agent view page, change the date range. Ensure the agent view page is updated correctly. 🟢 🟢

Details

🟢 Go to Server management -> Endpoint Summary and click on active agent. Ensure the agent view page is rendered correctly.

Chrome - 🟢
image

Firefox - 🟢

image

Safari - ⚫

🟢 Go to Server management -> Endpoint Summary and click on never connected agent. It should render a message and a button to select an agent.

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 Select an agent from the previous step. Ensure the agent view page is rendered correctly.

Chrome - 🟢

Evidence_1_Chrome.webm

Firefox - 🟢

Evidence_1_Firefox.webm

Safari - ⚫

🟢 On agent view page, click to unpinned agent. It should render a message and a button to select an agent.

Chrome - 🟢

Evidence_2_Chrome.webm

Firefox - 🟢

Evidence_2_Firefox.webm

Safari - ⚫

🟢 On agent view page, click to select another agent. Ensure the agent view page is updated correctly.

Chrome - 🟢

Evidence_3_Chrome.webm

Firefox - 🟢

Evidence_3_Firefox.webm

Safari - ⚫

🟢 On agent view page, click the Inventory data button. Ensure the Inventory data page and the url are updated correctly.

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 On agent view page, click the Stat button. Ensure the Stat page and the url are updated correctly.

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 On agent view page, click the Configuration button. Ensure the Configuration page and the url are updated correctly.

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 On agent view page, manually update the url with a non-unexistent agent. It should render an error.

Used relative URL: /app/endpoints-summary#/agents?tab=welcome&agent=noagent

Chrome - 🟢

image

Firefox - 🟢

image

Safari - ⚫

🟢 On agent view page, change the date range. Ensure the agent view page is updated correctly.

Chrome - 🟢

Evidence_4_Chrome.webm

Firefox - 🟢

Evidence_4_Firefox.webm

Safari - ⚫

jbiset
jbiset previously approved these changes Apr 26, 2024
JuanGarriuz
JuanGarriuz previously approved these changes Apr 29, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: we could have moved the file instead of creating a new one through copying it. Moving follows the tracking of the commits of the old file.

@lucianogorza lucianogorza dismissed stale reviews from JuanGarriuz and jbiset via 3d19dc6 April 29, 2024 14:49
@asteriscos asteriscos merged commit aee0268 into 4.9.0 Apr 29, 2024
1 check passed
@asteriscos asteriscos deleted the enhancement/6548-refactor-angularjs-agent-controller branch April 29, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Refactor angularJS agent.js
5 participants