-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove agent AngularJS controller #6618
Remove agent AngularJS controller #6618
Conversation
TestLegend: UI
Details 🟢 Go to Server management -> Endpoint Summary and click on active agent. Ensure the agent view page is rendered correctly.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Go to Server management -> Endpoint Summary and click on never connected agent. It should render a message and a button to select an agent.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Select an agent from the previous step. Ensure the agent view page is rendered correctly.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 On agent view page, click to unpinned agent. It should render a message and a button to select an agent.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 On agent view page, click to select another agent. Ensure the agent view page is updated correctly.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 On agent view page, click the Inventory data button. Ensure the Inventory data page and the url are updated correctly.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 On agent view page, click the Stat button. Ensure the Stat page and the url are updated correctly.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 On agent view page, click the Configuration button. Ensure the Configuration page and the url are updated correctly.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 On agent view page, manually update the url with a non-unexistent agent. It should render an error.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
plugins/main/public/components/common/welcome/agents-welcome.js
Outdated
Show resolved
Hide resolved
CR: 🟢Test UI: 🟢Legend:
Details 🟢 Go to Server management -> Endpoint Summary and click on active agent. Ensure the agent view page is rendered correctly.Firefox - 🟢 Safari - ⚫ 🟢 Go to Server management -> Endpoint Summary and click on never connected agent. It should render a message and a button to select an agent.Chrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 Select an agent from the previous step. Ensure the agent view page is rendered correctly.Chrome - 🟢 Evidence_1_Chrome.webmFirefox - 🟢 Evidence_1_Firefox.webmSafari - ⚫ 🟢 On agent view page, click to unpinned agent. It should render a message and a button to select an agent.Chrome - 🟢 Evidence_2_Chrome.webmFirefox - 🟢 Evidence_2_Firefox.webmSafari - ⚫ 🟢 On agent view page, click to select another agent. Ensure the agent view page is updated correctly.Chrome - 🟢 Evidence_3_Chrome.webmFirefox - 🟢 Evidence_3_Firefox.webmSafari - ⚫ 🟢 On agent view page, click the Inventory data button. Ensure the Inventory data page and the url are updated correctly.Chrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 On agent view page, click the Stat button. Ensure the Stat page and the url are updated correctly.Chrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 On agent view page, click the Configuration button. Ensure the Configuration page and the url are updated correctly.Chrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 On agent view page, manually update the url with a non-unexistent agent. It should render an error.Used relative URL: /app/endpoints-summary#/agents?tab=welcome&agent=noagent Chrome - 🟢 Firefox - 🟢 Safari - ⚫ 🟢 On agent view page, change the date range. Ensure the agent view page is updated correctly.Chrome - 🟢 Evidence_4_Chrome.webmFirefox - 🟢 Evidence_4_Firefox.webmSafari - ⚫ |
plugins/main/public/components/common/welcome/dashboard/events-count.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: we could have moved the file instead of creating a new one through copying it. Moving follows the tracking of the commits of the old file.
Description
This pull request removes the agent AngularJS controller.
Issues Resolved
#6548
Evidence
Navigate from Endpoint Summary and change date range
initial-view.webm
Navigate with never connected agent
never-connected-agent.webm
Unpinned and change agent
unpinned-and-change-agent.webm
Update url when change tab
url-update.webm
Input new url
input-new-url.webm
Input url with not found agent
not-found-agent.webm
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Go to Server management -> Endpoint Summary and click on active agent. Ensure the agent view page is rendered correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to Server management -> Endpoint Summary and click on never connected agent. It should render a message and a button to select an agent.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Select an agent from the previous step. Ensure the agent view page is rendered correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ On agent view page, click to unpinned agent. It should render a message and a button to select an agent.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ On agent view page, click to select another agent. Ensure the agent view page is updated correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ On agent view page, click the Inventory data button. Ensure the Inventory data page and the url are updated correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ On agent view page, click the Stat button. Ensure the Stat page and the url are updated correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ On agent view page, click the Configuration button. Ensure the Configuration page and the url are updated correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ On agent view page, manually update the url with a non-unexistent agent. It should render an error.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ On agent view page, change the date range. Ensure the agent view page is updated correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest