Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vulnerabilities default index pattern #6642

Merged
merged 2 commits into from
May 7, 2024
Merged

Change vulnerabilities default index pattern #6642

merged 2 commits into from
May 7, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented May 6, 2024 •
edited
Loading

Description

This pull request changes the default vulnerabilities index pattern to wazuh-states-vulnerabilities-* to support the segregation of indexes by cluster name.

Issues Resolved

Closes #6641

Evidence

image

image

image

Test

Important

Test this PR with a new dev environment

  • Go to Dashboard Management -> App Settings and verify the setting vulnerabilities.pattern has the value wazuh-states-vulnerabilities-*

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this May 6, 2024
@asteriscos asteriscos linked an issue May 6, 2024 that may be closed by this pull request
Add wildcard to the default vulnerabilities index pattern #6641
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Main plugin code coverage (Jest) test % values
Statements 12.19% ( 4234 / 34727 )
Branches 8.28% ( 1928 / 23280 )
Functions 11.58% ( 959 / 8277 )
Lines 12.36% ( 4122 / 33330 )

jbiset
jbiset approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

AppSettings

image

Vulnerability detection dashboard

image

Inventory flyout

image

@lucianogorza lucianogorza self-requested a review May 6, 2024 19:27
lucianogorza
lucianogorza approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image
image
image

@asteriscos asteriscos merged commit 8c567f5 into 4.8.0 May 7, 2024
4 checks passed
@asteriscos asteriscos deleted the change/default-vulnerabilities-index-pattern-wildcard-6641 branch May 7, 2024 07:50
@asteriscos asteriscos mentioned this pull request May 14, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucianogorza lucianogorza lucianogorza approved these changes

@jbiset jbiset jbiset approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wildcard to the default vulnerabilities index pattern
3 participants
@asteriscos @jbiset @lucianogorza