Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statistics remove pinned agent #6682

Merged
merged 2 commits into from
May 16, 2024
Merged

Statistics remove pinned agent #6682

merged 2 commits into from
May 16, 2024

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented May 16, 2024 •
edited
Loading

Description

This PR, removes the pinned agent filter in the statistics dashboard

Issues Resolved

Evidence

Before

Statistics_before

After

Statistics_after

Test

  • Go to a module and pin an agent.
  • Having the agent pinned go to Server management -> Statistics
  • Check that the opensearch request does not contain the pinned agent filter, nor allow agents or hide manager alerts.
  • Return to the beginning module or another module and check that the agent is still pinned.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset self-assigned this May 16, 2024
@jbiset jbiset changed the base branch from master to 4.9.0 May 16, 2024 15:17
@jbiset jbiset mentioned this pull request May 16, 2024
Closed
14 tasks
@jbiset jbiset linked an issue May 16, 2024 that may be closed by this pull request
Refine filter mechanism #6672
Closed
14 tasks
Machi3mfl
Machi3mfl approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Screen.Recording.2024-05-16.at.12.43.12.mov

@asteriscos asteriscos changed the title Fix/6672 statistics remove pinned agent Statistics remove pinned agent May 16, 2024
@asteriscos
Copy link
Member

asteriscos commented May 16, 2024 •
edited
Loading

Test 🟢

No agent.id filters applied
image

Agent keeps being pinned
Peek 2024-05-16 18-20

@asteriscos asteriscos merged commit ad88048 into 4.9.0 May 16, 2024
1 check passed
@asteriscos asteriscos deleted the fix/6672-statistics-remove-pinned-agent branch May 16, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

Assignees

@jbiset jbiset

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine filter mechanism
3 participants
@jbiset @asteriscos @Machi3mfl