Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discover flyout and improve events columns #6691

Merged
merged 7 commits into from
May 24, 2024

Conversation

lucianogorza
Copy link
Contributor

@lucianogorza lucianogorza commented May 21, 2024

Description

  • The error that occurred when trying to open the Events tab flyout in the modules has been fixed.
  • The rendering of the rule.id and rule.mitre.id columns has been improved to render a link, and the timestamp column now formats the date in all modules where it is displayed.
  • The rendering of those columns in each module has been removed so they use the general rendering.

Issues Resolved

#6672

Evidence

image
image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Threat Hunting

Test Chrome Firefox Safari
Check that the flyout opens correctly.
Check that the columns agent id and agent name don't have links for agent 000.
Check that the column agent id has a link and works correctly for other agents.
Check that the column agent name has a link and works correctly for other agents.
Check that the column rule.id has a link and works correctly.
Check that the column rule.mitre.id has a link and works correctly.
Check that the column timestamp renders correctly.

Details

⚫ Check that the flyout opens correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the columns agent id and agent name don't have links for agent 000.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column agent id has a link and works correctly for other agents.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column agent name has a link and works correctly for other agents.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column rule.id has a link and works correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column rule.mitre.id has a link and works correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column timestamp renders correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Mitre ATT&CT

Test Chrome Firefox Safari
Check that the flyout opens correctly.
Check that the columns agent id and agent name don't have links for agent 000.
Check that the column agent id has a link and works correctly for other agents.
Check that the column agent name has a link and works correctly for other agents.
Check that the column rule.id has a link and works correctly.
Check that the column rule.mitre.id has a link and works correctly.
Check that the column timestamp renders correctly.

Details

⚫ Check that the flyout opens correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the columns agent id and agent name don't have links for agent 000.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column agent id has a link and works correctly for other agents.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column agent name has a link and works correctly for other agents.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column rule.id has a link and works correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column rule.mitre.id has a link and works correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check that the column timestamp renders correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@lucianogorza lucianogorza self-assigned this May 21, 2024
@lucianogorza lucianogorza linked an issue May 21, 2024 that may be closed by this pull request
14 tasks
@lucianogorza lucianogorza mentioned this pull request May 21, 2024
14 tasks
@lucianogorza lucianogorza marked this pull request as ready for review May 21, 2024 19:23
@JuanGarriuz JuanGarriuz self-requested a review May 22, 2024 09:24
@JuanGarriuz
Copy link
Member

JuanGarriuz commented May 22, 2024

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Threat Hunting

Test Chrome Firefox Safari
Check that the flyout opens correctly. 🟢
Check that the columns agent id and agent name don't have links for agent 000. 🟢
Check that the column agent id has a link and works correctly for other agents. 🟢
Check that the column agent name has a link and works correctly for other agents. 🟢
Check that the column rule.id has a link and works correctly. 🟢
Check that the column rule.mitre.id has a link and works correctly. 🟢
Check that the column timestamp renders correctly. 🟢

Details

🟢 Check that the flyout opens correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Check that the columns agent id and agent name don't have links for agent 000.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Check that the column agent id has a link and works correctly for other agents.

Chrome - 🟢

image
image

Agent id is 002, although his name is ubutu_3

Firefox - ⚫

Safari - ⚫

🟢 Check that the column agent name has a link and works correctly for other agents.

Chrome - 🟢

image

image

Firefox - ⚫

Safari - ⚫

🟢 Check that the column rule.id has a link and works correctly.

Chrome - 🟢

image
image

Firefox - ⚫

Safari - ⚫

🟢 Check that the column rule.mitre.id has a link and works correctly.

Chrome - 🟢

image
image

Firefox - ⚫

Safari - ⚫

🟢 Check that the column timestamp renders correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

Mitre ATT&CT

Test Chrome Firefox Safari
Check that the flyout opens correctly. 🟢
Check that the columns agent id and agent name don't have links for agent 000. 🟢
Check that the column agent id has a link and works correctly for other agents. 🟢
Check that the column agent name has a link and works correctly for other agents. 🟢
Check that the column rule.id has a link and works correctly. 🟢
Check that the column rule.mitre.id has a link and works correctly. 🟢
Check that the column timestamp renders correctly. 🟢

Details

🟢 Check that the flyout opens correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Check that the columns agent id and agent name don't have links for agent 000.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Check that the column agent id has a link and works correctly for other agents.

Chrome - 🟢

image
image

Firefox - ⚫

Safari - ⚫

🟢 Check that the column agent name has a link and works correctly for other agents.

Chrome - 🟢

image
image

Firefox - ⚫

Safari - ⚫

🟢 Check that the column rule.id has a link and works correctly.

Chrome - 🟢

image
image

Firefox - ⚫

Safari - ⚫

🟢 Check that the column rule.mitre.id has a link and works correctly.

Chrome - 🟢

image
image

Firefox - ⚫

Safari - ⚫

🟢 Check that the column timestamp renders correctly.

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

@Machi3mfl Machi3mfl self-requested a review May 22, 2024 11:23
JuanGarriuz
JuanGarriuz previously approved these changes May 22, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Machi3mfl
Copy link
Member

Machi3mfl commented May 23, 2024

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Threat Hunting

Test Chrome Firefox Safari
Check that the flyout opens correctly. 🟢
Check that the columns agent id and agent name don't have links for agent 000. 🟢
Check that the column agent id has a link and works correctly for other agents. 🟢
Check that the column agent name has a link and works correctly for other agents. 🟢
Check that the column rule.id has a link and works correctly. 🟢
Check that the column rule.mitre.id has a link and works correctly. 🟢
Check that the column timestamp renders correctly. 🟢

Details

🟢 Check that the flyout opens correctly.

Chrome - 🟢

Screen.Recording.2024-05-23.at.08.23.29.mov

Firefox - ⚫

Safari - ⚫

🟢 Check that the columns agent id and agent name don't have links for agent 000.

Chrome - 🟢

Screenshot 2024-05-23 at 08 25 41

Firefox - ⚫

Safari - ⚫

🟢 Check that the column agent id has a link and works correctly for other agents.

Chrome - 🟢

Screen.Recording.2024-05-23.at.08.49.06.mov

Firefox - ⚫

Safari - ⚫

🟢 Check that the column agent name has a link and works correctly for other agents.

Chrome - 🟢

Screen.Recording.2024-05-23.at.08.50.03.mov

Firefox - ⚫

Safari - ⚫

🟢 Check that the column rule.id has a link and works correctly.

Chrome - 🟢

Screen.Recording.2024-05-23.at.08.27.45.mov

Firefox - ⚫

Safari - ⚫

🟢 Check that the column rule.mitre.id has a link and works correctly.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Check that the column timestamp renders correctly.

Chrome - 🟢

Screenshot 2024-05-23 at 08 30 13

Firefox - ⚫

Safari - ⚫

Mitre ATT&CK

Test Chrome Firefox Safari
Check that the flyout opens correctly. 🟢
Check that the columns agent id and agent name don't have links for agent 000. 🟢
Check that the column agent id has a link and works correctly for other agents. 🟢
Check that the column agent name has a link and works correctly for other agents. 🟢
Check that the column rule.id has a link and works correctly. 🟢
Check that the column rule.mitre.id has a link and works correctly. 🟢
Check that the column timestamp renders correctly. 🟢

Details

🟢 Check that the flyout opens correctly.

Chrome - 🟢

Screen.Recording.2024-05-23.at.08.33.04.mov

Firefox - ⚫

Safari - ⚫

🟢 Check that the columns agent id and agent name don't have links for agent 000.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Check that the column agent id has a link and works correctly for other agents.

Chrome - 🟢

Screen.Recording.2024-05-23.at.08.40.52.mov

Firefox - ⚫

Safari - ⚫

🟢 Check that the column agent name has a link and works correctly for other agents.

Chrome - 🟢

Screen.Recording.2024-05-23.at.08.41.53.mov

Firefox - ⚫

Safari - ⚫

🟢 Check that the column rule.id has a link and works correctly.

Chrome - 🟢

Screen.Recording.2024-05-23.at.08.43.21.mov

Firefox - ⚫

Safari - ⚫

🟢 Check that the column rule.mitre.id has a link and works correctly.

Chrome - 🟢

Screen.Recording.2024-05-23.at.08.44.42.mov

Firefox - ⚫

Safari - ⚫

🟢 Check that the column timestamp renders correctly.

Chrome - 🟢

Screenshot 2024-05-23 at 08 45 19

Firefox - ⚫

Safari - ⚫

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

@asteriscos asteriscos merged commit cc5fc3f into 4.9.0 May 24, 2024
1 check passed
@asteriscos asteriscos deleted the fix/6672-check-flyout-discover-table branch May 24, 2024 12:20
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine filter mechanism
4 participants