-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix discover flyout and improve events columns #6691
Conversation
TestLegend: Threat Hunting
Details 🟢 Check that the columns agent id and agent name don't have links for agent 000.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Check that the column agent id has a link and works correctly for other agents.Chrome - 🟢
Firefox - ⚫ Safari - ⚫ 🟢 Check that the column agent name has a link and works correctly for other agents.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Check that the column rule.mitre.id has a link and works correctly.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ Mitre ATT&CT
Details 🟢 Check that the columns agent id and agent name don't have links for agent 000.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Check that the column agent id has a link and works correctly for other agents.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Check that the column agent name has a link and works correctly for other agents.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Check that the column rule.mitre.id has a link and works correctly.Chrome - 🟢 Firefox - ⚫ Safari - ⚫ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
Test: ✅
Description
Events
tab flyout in the modules has been fixed.rule.id
andrule.mitre.id
columns has been improved to render a link, and thetimestamp
column now formats the date in all modules where it is displayed.Issues Resolved
#6672
Evidence
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
Threat Hunting
Details
⚫ Check that the flyout opens correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the columns agent id and agent name don't have links for agent 000.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column agent id has a link and works correctly for other agents.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column agent name has a link and works correctly for other agents.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column rule.id has a link and works correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column rule.mitre.id has a link and works correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column timestamp renders correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Mitre ATT&CT
Details
⚫ Check that the flyout opens correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the columns agent id and agent name don't have links for agent 000.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column agent id has a link and works correctly for other agents.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column agent name has a link and works correctly for other agents.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column rule.id has a link and works correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column rule.mitre.id has a link and works correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Check that the column timestamp renders correctly.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest