Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default vulnerabilities tables columns fields #6703

Merged
merged 2 commits into from
May 23, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented May 23, 2024

Description

This pull request changes the default vulnerabilities tables columns fields.

Issues Resolved

Closes #6700

Evidence

Inventory

image

Events

image

Test

  • Check the default fields in Vulnerabilities / Inventory table are:

    • agent.name
    • package.name
    • package.version
    • vulnerability.description
    • vulnerability.severity
    • vulnerability.id
  • Check the Vulnerabilities / Events table default fields and order are:

    • time
    • agent.name
    • data.vulnerability.severity
    • data.vulnerability.cve
    • data.vulnerability.package.name

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this May 23, 2024
@asteriscos asteriscos linked an issue May 23, 2024 that may be closed by this pull request
2 tasks
@yenienserrano yenienserrano self-requested a review May 23, 2024 13:48
@yenienserrano
Copy link
Member

Test

  • Check the default fields in Vulnerabilities / Inventory table are:

    • agent.name
    • package.name
    • package.version
    • vulnerability.description (bigger than the others)
    • vulnerability.id
    • vulneravility.severity
Details image
  • Check the Vulnerabilities / Events table default fields and order are:
    • time
    • agent.name
    • data.vulnerability.severity
    • data.vulnerability.cve
    • data.vulnerability.package.name
Details image

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

@lucianogorza lucianogorza self-requested a review May 23, 2024 14:49
@lucianogorza
Copy link
Contributor

lucianogorza commented May 23, 2024

CR 🟢

Test 🟢

  • Check the default fields in Vulnerabilities / Inventory table are:

    • agent.name
    • package.name
    • package.version
    • vulnerability.description (bigger than the others)
    • vulnerability.id
    • vulneravility.severity
Details

image

  • Check the Vulnerabilities / Events table default fields and order are:
    • time
    • agent.name
    • data.vulnerability.severity
    • data.vulnerability.cve
    • data.vulnerability.package.name
Details

image

@asteriscos asteriscos merged commit ed8ad60 into 4.8.0 May 23, 2024
4 checks passed
@asteriscos asteriscos deleted the change/vulnerabilities-tables-columns-fields-6700 branch May 23, 2024 15:35
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.3% ( 4278 / 34779 )
Branches 8.31% ( 1938 / 23294 )
Functions 11.63% ( 964 / 8284 )
Lines 12.48% ( 4168 / 33383 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change vulnerabilities tables columns fields
3 participants