Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Wazuh Searchbar component #6716

Merged
merged 18 commits into from
May 30, 2024

Conversation

lucianogorza
Copy link
Contributor

@lucianogorza lucianogorza commented May 28, 2024

Description

This PR addresses the current issue with the OpenSearch search bar by introducing a new Wazuh Searchbar component. The native OpenSearch search bar's functionality and appearance were being altered to extend its capabilities, leading to unexpected behavior in some cases.

Changes Made:

  • Created a new Wazuh Searchbar component.
  • Implemented internal handling for both fixed and user-added filters.
  • Ensured the display of filters is consistent and correct without unexpected behavior.
  • Removed alterations to the native OpenSearch search bar.

Issues Resolved

#6711

Evidence

image

image

image

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Test Chrome Firefox Safari
Threat Hunting (Dashboard)
Malware Detection (Dashboard)
FIM (Dashboard and Inventory)
Mitre Att&ct (Dashboard and Framework)
Vulnerability Detection (Dashboard and Inventory)
Virus Total (Dashboard)
PCI DSS (Dashboard and Controls)
GDPR (Dashboard and Controls)
HIPAA (Dashboard and Controls)
NIST (Dashboard and Controls)
TSC (Dashboard and Controls)
Docker (Dashboard)
AWS (Dashboard)
Google Cloud (Dashboard)
GitHub (Dashboard and Panel)
Office 365 (Dashboard and Panel)
Server Management -> Cluster
Wazuh Discover (any Events tab)

Details

⚫ Threat Hunting (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Malware Detection (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ FIM (Dashboard and Inventory)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Mitre Att&ct (Dashboard and Framework)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Vulnerability Detection (Dashboard and Inventory)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Virus Total (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ PCI DSS (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ GDPR (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ HIPAA (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ NIST (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ TSC (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Docker (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ AWS (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Google Cloud (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ GitHub (Dashboard and Panel)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Office 365 (Dashboard and Panel)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Server Management -> Cluster

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Wazuh Discover (any Events tab)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@lucianogorza lucianogorza self-assigned this May 28, 2024
@lucianogorza lucianogorza changed the title Enhancenment/6711 create wazuh searchbar component Create Wazuh Searchbar component May 28, 2024
@lucianogorza lucianogorza force-pushed the enhancenment/6711-create-wazuh-searchbar-component branch from e28cef6 to 29d9abc Compare May 29, 2024 17:17
@lucianogorza lucianogorza linked an issue May 29, 2024 that may be closed by this pull request
25 tasks
@lucianogorza lucianogorza marked this pull request as ready for review May 29, 2024 20:19
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Change all filters button must be hidden in all dashboards.

image

@lucianogorza
Copy link
Contributor Author

The Change all filters button must be hidden in all dashboards.

image

The Change all filters button is enabled on purpose, as it only acts on the filters added by the user. Previously, it was hidden because it also applied to the fixed filters.

@yenienserrano
Copy link
Member

yenienserrano commented May 30, 2024

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Test Chrome Firefox Safari
Threat Hunting (Dashboard) 🟢
Malware Detection (Dashboard) 🟢
FIM (Dashboard and Inventory) 🟢
Mitre Att&ct (Dashboard and Framework) 🟢
Vulnerability Detection (Dashboard and Inventory) 🟢
Virus Total (Dashboard) 🟢
PCI DSS (Dashboard and Controls) 🟢
GDPR (Dashboard and Controls) 🟢
HIPAA (Dashboard and Controls) 🟢
NIST (Dashboard and Controls) 🟢
TSC (Dashboard and Controls) 🟢
Docker (Dashboard) 🟢
AWS (Dashboard) 🟢
Google Cloud (Dashboard) 🟢
GitHub (Dashboard and Panel) 🟢
Office 365 (Dashboard and Panel) 🟢
Server Management -> Cluster 🟢
Wazuh Discover (any Events tab) 🟢

Details

🟢 Threat Hunting (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image
🟢 Malware Detection (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image
🟢 FIM (Dashboard and Inventory)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image
🟢 Mitre Att&ct (Dashboard and Framework)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image image
🟢 Vulnerability Detection (Dashboard and Inventory)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image image
🟢 Virus Total (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image
🟢 PCI DSS (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image image
🟢 GDPR (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image image
🟢 HIPAA (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image image
🟢 NIST (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image image
🟢 TSC (Dashboard and Controls)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image image
🟢 Docker (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image
🟢 AWS (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image
🟢 Google Cloud (Dashboard)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image
🟢 GitHub (Dashboard and Panel)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image image
🟢 Office 365 (Dashboard and Panel)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image image
🟢 Server Management -> Cluster

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image
🟢 Wazuh Discover (any Events tab)

Chrome - ⚫

Firefox - ⚫

Safari - 🟢

image

@yenienserrano yenienserrano self-requested a review May 30, 2024 13:16
yenienserrano
yenienserrano previously approved these changes May 30, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

@chantal-kelm chantal-kelm self-requested a review May 30, 2024 15:55
@chantal-kelm
Copy link
Member

chantal-kelm commented May 30, 2024

Test IN PROGRESS

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Test Chrome Firefox Safari
Threat Hunting (Dashboard) 🟢
Malware Detection (Dashboard) 🟢
FIM (Dashboard and Inventory) 🟢
Mitre Att&ct (Dashboard and Framework) 🟢
Vulnerability Detection (Dashboard and Inventory) 🟢
Virus Total (Dashboard) 🟢
PCI DSS (Dashboard and Controls) 🟢
GDPR (Dashboard and Controls) 🟢
HIPAA (Dashboard and Controls) 🟢
NIST (Dashboard and Controls) 🟢
TSC (Dashboard and Controls) 🟢
Docker (Dashboard) 🟢
AWS (Dashboard) 🟢
Google Cloud (Dashboard) 🟢
GitHub (Dashboard and Panel) 🟢
Office 365 (Dashboard and Panel) 🟢
Server Management -> Cluster 🟢
Wazuh Discover (any Events tab) 🟢

Details

🟢 Threat Hunting (Dashboard)

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Malware Detection (Dashboard)

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 FIM (Dashboard and Inventory)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 Mitre Att&ct (Dashboard and Framework)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 Vulnerability Detection (Dashboard and Inventory)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 Virus Total (Dashboard)

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 PCI DSS (Dashboard and Controls)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 GDPR (Dashboard and Controls)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 HIPAA (Dashboard and Controls)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 NIST (Dashboard and Controls)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 TSC (Dashboard and Controls)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 Docker (Dashboard)

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 AWS (Dashboard)

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 Google Cloud (Dashboard)

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

🟢 GitHub (Dashboard and Panel)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 Office 365 (Dashboard and Panel)

Chrome - 🟢

image image

Firefox - ⚫

Safari - ⚫

🟢 Server Management -> Cluster

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Wazuh Discover (any Events tab)

Chrome - 🟢

image

Firefox - ⚫

Safari - ⚫

@asteriscos
Copy link
Member

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Test Chrome Firefox Safari
Threat Hunting (Dashboard) 🟢
Malware Detection (Dashboard) 🟢
FIM (Dashboard and Inventory) 🟢
Mitre Att&ct (Dashboard and Framework) 🟢
Vulnerability Detection (Dashboard and Inventory) 🟢
Virus Total (Dashboard) 🟢
PCI DSS (Dashboard and Controls) 🟢
GDPR (Dashboard and Controls) 🟢
HIPAA (Dashboard and Controls) 🟢
NIST (Dashboard and Controls) 🟢
TSC (Dashboard and Controls) 🟢
Docker (Dashboard) 🟢
AWS (Dashboard) 🟢
Google Cloud (Dashboard) 🟢
GitHub (Dashboard and Panel) 🟢
Office 365 (Dashboard and Panel) 🟢
Server Management -> Cluster 🟢

Details

🟢 Threat Hunting (Dashboard)

Chrome - 🟢

image

Safari - ⚪

🟢 Malware Detection (Dashboard)

Chrome - 🟢

image

Safari - ⚪

🟢 FIM (Dashboard and Inventory)

Chrome - 🟢

image

Safari - ⚫

🟢 Mitre Att&ct (Dashboard and Framework)

Chrome - 🟢

image

image

🟢 Vulnerability Detection (Dashboard and Inventory)

Chrome - 🟢

image

image

image

🟢 Virus Total (Dashboard)

Chrome - 🟢

image

🟢 PCI DSS (Dashboard and Controls)

Chrome - 🟢

image

image

image

🟢 GDPR (Dashboard and Controls)

Chrome - 🟢

image

image

image

🟢 HIPAA (Dashboard and Controls)

Chrome - 🟢

image

image

image

🟢 NIST (Dashboard and Controls)

Chrome - 🟢

image

image

image

🟢 TSC (Dashboard and Controls)

Chrome - 🟢

image

image

image

🟢 Docker (Dashboard)

Chrome - 🟢

image

image

🟢 AWS (Dashboard)

Chrome - 🟢

image

image

🟢 Google Cloud (Dashboard)

Chrome - 🟢

image

image

🟢 GitHub (Dashboard and Panel)

Chrome - 🟢

image

image

image

🟢 Office 365 (Dashboard and Panel)

Chrome - 🟢

image

image

image

image

🟢 Server Management -> Cluster

Chrome - 🟢

image

image

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

@asteriscos asteriscos merged commit 4a5ce30 into 4.9.0 May 30, 2024
1 check passed
@asteriscos asteriscos deleted the enhancenment/6711-create-wazuh-searchbar-component branch May 30, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Wazuh Searchbar component
4 participants