Fix switching tabs in the same module encodes the url

[chantal-kelm]

Description

Fix the url encoding.

Issues Resolved

#6773

Evidence

Modules

Grabacion.de.pantalla.2024-06-14.a.la.s.12.03.14.p.m.mov

Rules

Endpoint summary > Configuration > Endpoint groups

Grabacion.de.pantalla.2024-06-19.a.la.s.8.56.21.p.m.mov

Health-check

Grabacion.de.pantalla.2024-06-19.a.la.s.8.58.41.p.m.mov

FIM Inventory tab table

Grabacion.de.pantalla.2024-06-19.a.la.s.9.02.09.p.m.mov

Test

Verify that in the parts shown in the video evidence the url is not encoded, update and remove the url parameters if necessary.

Check List

• All tests pass
  • yarn test:jest
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[jbiset]

CR: 🔴 (Comments added)

Test UI 🔴

Chrome 🟢

Evidence.webm

Firefox 🔴

[Desvelao]

Some navigations are using the URLSearchParams constructor and composing the URL search parameters with the .toString method. According to the changes, it seems the fix is replace the usage of .toString() by a custom method to built the URL search parameters.

I guess this problem could appear in the remaining navigations that are using the URLSearchParamters.prototype.toString() method. In this case we should adapt too. For extension, we could create a custom constructor similar to URLSearchParameters with the implementation of URL search parameters build.

[JuanGarriuz]

Test 🟢

Modules

Chrome🟢

Grabacion.2024-06-11.123352.mp4

Rules

Chrome🟢

Endpoint Groups

Chrome🟢

Grabacion.2024-06-11.123352.mp4

Health Check

Chrome🟢

Grabacion.2024-06-11.123352.mp4

File Integrity Monitoring

Chrome🟢

Grabacion.2024-06-11.123352.mp4

[chantal-kelm]

Some navigations are using the URLSearchParams constructor and composing the URL search parameters with the .toString method. According to the changes, it seems the fix is replace the usage of .toString() by a custom method to built the URL search parameters.

I guess this problem could appear in the remaining navigations that are using the URLSearchParamters.prototype.toString() method. In this case we should adapt too. For extension, we could create a custom constructor similar to URLSearchParameters with the implementation of URL search parameters build.

As mentioned in this comment it was decided to make a more global solution that attacks all files with the same problem.

I am working on it.

[jbiset]

CR: 🟢

Test UI: 🟢

Modules 🟢

Chrome

Evidence1_Chrome.webm

Firefox

Evidence1_Firefox.webm

Rules 🟢

Chrome

Firefox

Endpoint summary > Configuration > Endpoint groups 🟢

Chrome

Evidence3_Chrome.webm

Firefox

Evidence3_Firefox.webm

Health-check 🟢

Chrome

Evidence4_Chrome.webm

Firefox

Evidence4_Firefox.webm

FIM Inventory tab table 🟢

Chrome

Evidence5_Chrome.webm

Firefox

Evidence5_Firefox.webm

[Desvelao]

LGTM!

[JuanGarriuz]

LGTM!!

[github-actions]

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	45.96%	( 399 / 868 )
Branches	41.97%	( 157 / 374 )
Functions	44.01%	( 136 / 309 )
Lines	46.16%	( 397 / 860 )

[github-actions]

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

[github-actions]

Main plugin code coverage (Jest) test	%	values
Statements	12.2%	( 3993 / 32717 )
Branches	8.11%	( 1743 / 21486 )
Functions	11.7%	( 944 / 8063 )
Lines	12.39%	( 3890 / 31386 )