Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pinned agent is not persisted on refreshing page #6790

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jun 20, 2024

Description

This pull request fixes a problem of pinned agent is not kept when refreshing the page.

Issues Resolved

#6788

Evidence

image

Test

Legend:
⚫: none
🟒: pass
🟑: warning
πŸ”΄: fail
βšͺ: not applicable

UI

Test Chrome Firefox Safari
With a view that displays the pinned agent, refresh the page, the pinned agent should keep pinned. ⚫ ⚫ ⚫

Details

⚫ With a view that displays the pinned agent, refresh the page, the pinned agent should keep pinned.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Jun 20, 2024
@Desvelao Desvelao linked an issue Jun 20, 2024 that may be closed by this pull request
@Desvelao Desvelao marked this pull request as ready for review June 20, 2024 10:02
@asteriscos asteriscos changed the title Fix pinned agent was not keet on refrshing page Fix pinned agent is not persisted on refreshing page Jun 20, 2024
@JuanGarriuz JuanGarriuz self-requested a review June 20, 2024 10:17
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟒

Grabacion.2024-06-11.123352.mp4

CR 🟒

LGTM!!

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.2% ( 3993 / 32718 )
Branches 8.11% ( 1743 / 21486 )
Functions 11.7% ( 944 / 8063 )
Lines 12.39% ( 3890 / 31387 )

Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟒

Test UI 🟒

Legend:
⚫: none
🟒: pass
🟑: warning
πŸ”΄: fail
βšͺ: not applicable

UI

Test Chrome Firefox Safari
With a view that displays the pinned agent, refresh the page, the pinned agent should keep pinned. 🟒 🟒 ⚫

Details

🟒 With a view that displays the pinned agent, refresh the page, the pinned agent should keep pinned.

Chrome - 🟒

Evidence_Chrome.webm

Firefox - 🟒

Evidence_Firefox.webm

Safari - ⚫

@lucianogorza lucianogorza merged commit dd2dec5 into 4.9.0 Jun 25, 2024
4 checks passed
@lucianogorza lucianogorza deleted the bug/6788-keep-pinned-agent-on-refresh-page branch June 25, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh the page do not keep the pinned agent
4 participants