Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add saved queries button to search bar #6833

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add saved queries button to search bar #6833

merged 2 commits into from
Jul 18, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 16, 2024 •
edited
Loading

Description

Add the save query button to the search bar of the dashboards.

Issues Resolved

Evidence

image

Test

  • Navigate to the different dashboards and events.
  • See that the Saved queries button appears and saves the filters external to the dashboard.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano changed the base branch from master to 4.9.0 July 16, 2024 18:56
@yenienserrano yenienserrano linked an issue Jul 16, 2024 that may be closed by this pull request
The saved queries button is missing #6829
Closed
@yenienserrano yenienserrano self-assigned this Jul 17, 2024
@yenienserrano yenienserrano marked this pull request as ready for review July 17, 2024 13:45
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29229 )
Branches 9.1% ( 1744 / 19149 )
Functions 13.35% ( 943 / 7062 )
Lines 13.83% ( 3886 / 28091 )

@JuanGarriuz JuanGarriuz self-requested a review July 18, 2024 06:10
JuanGarriuz
JuanGarriuz approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

image

CR 🟢

LGTM!!

jbiset
jbiset approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

@Tostti Tostti merged commit 471203a into 4.9.0 Jul 18, 2024
5 checks passed
@Tostti Tostti deleted the bug/6829-the-saved-queries-button-is-missing branch July 18, 2024 14:55
@Tostti Tostti restored the bug/6829-the-saved-queries-button-is-missing branch July 19, 2024 11:48
@Tostti Tostti deleted the bug/6829-the-saved-queries-button-is-missing branch July 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@jbiset jbiset jbiset approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The saved queries button is missing
4 participants
@yenienserrano @jbiset @JuanGarriuz @Tostti