Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field links in discover document details #6843

Merged

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Jul 18, 2024

Description

Add field links in discover document details

Closes #6837

Evidence

Screenshot 2024-07-18 at 09 54 15

Tests

  • Check the Threat Hunting data grid. The flyout details must have the same links as the table
Screen.Recording.2024-07-18.at.09.56.14.mov
  • Check the modules Events tab data grid. The flyout details must have the same links as the table
Screen.Recording.2024-07-18.at.09.58.22.mov
Screen.Recording.2024-07-18.at.09.58.49.mov
  • Check the module Vulnerability Detection Inventory tab data grid. The flyout details must have the same links as the table
Screen.Recording.2024-07-19.at.13.01.11.mov

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl linked an issue Jul 19, 2024 that may be closed by this pull request
@yenienserrano yenienserrano self-requested a review July 22, 2024 11:54
@chantal-kelm chantal-kelm self-requested a review July 22, 2024 12:29
@yenienserrano
Copy link
Member

The agent.name link does not work

image

@Machi3mfl
Copy link
Member Author

The agent.name link does not work

image

Solved in ddb8905

Screen.Recording.2024-07-22.at.13.50.01.mov

@yenienserrano
Copy link
Member

Test: 🟢

image

image

image

yenienserrano
yenienserrano previously approved these changes Jul 23, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

chantal-kelm
chantal-kelm previously approved these changes Jul 23, 2024
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

🟢 Check the Threat Hunting data grid. The flyout details must have the same links as the table

Grabacion.de.pantalla.2024-07-23.a.la.s.9.32.59.a.m.mov

🟢 Check the modules Events tab data grid. The flyout details must have the same links as the table

Grabacion.de.pantalla.2024-07-23.a.la.s.9.40.18.a.m.mov
Grabacion.de.pantalla.2024-07-23.a.la.s.9.45.44.a.m.mov

🟢 Check the module Vulnerability Detection Inventory tab data grid. The flyout details must have the same links as the table

Grabacion.de.pantalla.2024-07-23.a.la.s.9.53.06.a.m.mov

@Machi3mfl Machi3mfl dismissed stale reviews from chantal-kelm and yenienserrano via 2fc79f5 July 23, 2024 13:18
yenienserrano
yenienserrano previously approved these changes Jul 24, 2024
@chantal-kelm chantal-kelm self-requested a review July 24, 2024 16:09
chantal-kelm
chantal-kelm previously approved these changes Jul 24, 2024
@chantal-kelm chantal-kelm self-requested a review July 26, 2024 17:50
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.63% ( 3990 / 29253 )
Branches 9.1% ( 1744 / 19163 )
Functions 13.35% ( 943 / 7062 )
Lines 13.82% ( 3887 / 28117 )

@lucianogorza lucianogorza merged commit 3f1d8cb into 4.9.0 Jul 26, 2024
5 checks passed
@lucianogorza lucianogorza deleted the fix/6837-add-field-links-discover-documenta-details branch July 26, 2024 20:15
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing module links in Documents Details Flyout in Discover
4 participants