-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the text of the query limit tooltip #6981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidomodarelli
changed the title
style: Update warning message for query results limit
Change the text of the query limit tooltip
Sep 9, 2024
guidomodarelli
requested review from
Machi3mfl,
asteriscos,
jbiset and
Desvelao
and removed request for
Machi3mfl,
asteriscos and
jbiset
September 9, 2024 21:02
This reverts commit 0989f5b.
This reverts commit e835ab8.
|
|
|
Desvelao
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Machi3mfl
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The text of the query limit tooltip is too long. We have to change it to "The query results exceeded the limit of MAX_ENTRIES_PER_QUERY hits. Please refine your search"
Issues Resolved
#6979
Evidence
Test
You need add Sample Data and edit some lines:
wazuh-dashboard-plugins/plugins/main/public/components/common/wazuh-discover/wz-flyout-discover.tsx
Line 299 in 9f29914
wazuh-dashboard-plugins/plugins/main/public/components/overview/vulnerabilities/dashboards/inventory/inventory.tsx
Line 220 in 3f1d8cb
wazuh-dashboard-plugins/plugins/main/public/components/common/wazuh-discover/components/data-grid-additional-controls.tsx
Line 42 in a8bb0f3
Place the cursor over the warning icon.
Check List
yarn test:jest