Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the text of the query limit tooltip #6981

Merged
merged 8 commits into from
Sep 11, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 9, 2024

Description

The text of the query limit tooltip is too long. We have to change it to "The query results exceeded the limit of MAX_ENTRIES_PER_QUERY hits. Please refine your search"

Issues Resolved

#6979

Evidence

image

image

Test

You need add Sample Data and edit some lines:

  1. Go to Threat intelligence > Threat Hunting
  2. Go to Threat intelligence > Vulnerability Detection

Place the cursor over the warning icon.

image

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli linked an issue Sep 9, 2024 that may be closed by this pull request
@guidomodarelli guidomodarelli changed the title style: Update warning message for query results limit Change the text of the query limit tooltip Sep 9, 2024
@guidomodarelli guidomodarelli self-assigned this Sep 9, 2024
@guidomodarelli guidomodarelli requested review from Machi3mfl, asteriscos, jbiset and Desvelao and removed request for Machi3mfl, asteriscos and jbiset September 9, 2024 21:02
@guidomodarelli guidomodarelli changed the base branch from master to 4.10.0 September 9, 2024 21:03
@guidomodarelli guidomodarelli changed the base branch from 4.10.0 to 4.9.1 September 9, 2024 21:09
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Main plugin code coverage (Jest) test % values
Statements 13.59% ( 4016 / 29537 )
Branches 9.09% ( 1755 / 19302 )
Functions 13.31% ( 947 / 7111 )
Lines 13.77% ( 3914 / 28421 )

@Desvelao
Copy link
Member

🟢 Test

image
image
image

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screenshot 2024-09-10 at 09 48 16 Screenshot 2024-09-10 at 09 47 14

@Desvelao Desvelao merged commit 5f1b817 into 4.9.1 Sep 11, 2024
5 checks passed
@Desvelao Desvelao deleted the change/6979-change-query-limit-tooltip branch September 11, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the text of the query limit tooltip
3 participants