Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The automatic page refresh is not working in Wazuh Dashboard in version 4.9.0 #7016

Closed
wants to merge 26 commits into from
Closed

The automatic page refresh is not working in Wazuh Dashboard in version 4.9.0 #7016

wants to merge 26 commits into from

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 25, 2024 •
edited
Loading

Description

The automatic page refresh is not working properly for the Wazuh Dashboard in version 4.9.0. The page is refreshing but it is not updating the changes on the Dashboard.
image

Issues Resolved

#25617

Evidence

Peek.2024-09-25.11-44.mp4

Test

  1. Remove the sample data, if present.
  2. Add the sample data to obtain the latest timestamps.
  3. Navigate to any application.
  4. Set a refresh interval of 5 seconds within the time filter.
  5. Observe whether the histogram updates over time.

Important

  1. Check if the URL updates with the savedQuery when you select an option or clear all (savedQueries)
  2. Additionally, verify that the AppFilters are being saved correctly in the URL
Peek.2024-09-27.13-27.mp4

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli linked an issue Sep 25, 2024 that may be closed by this pull request
The automatic page refresh is not working in Wazuh Dashboard in version 4.9.0 wazuh/wazuh#25617
Closed
@guidomodarelli guidomodarelli changed the title Bug/25617 the automatic page refresh is not working The automatic page refresh is not working in Wazuh Dashboard in version 4.9.0 Sep 25, 2024
@guidomodarelli guidomodarelli marked this pull request as draft September 25, 2024 16:54
@guidomodarelli guidomodarelli force-pushed the bug/25617-the-automatic-page-refresh-is-not-working branch from 9ee0221 to f76985d Compare September 27, 2024 11:27
@guidomodarelli guidomodarelli marked this pull request as ready for review September 27, 2024 12:56
@guidomodarelli guidomodarelli force-pushed the bug/25617-the-automatic-page-refresh-is-not-working branch 2 times, most recently from 1c4fe66 to e92c395 Compare September 27, 2024 13:06
chantal-kelm

This comment was marked as outdated.

Sign in to view

@Machi3mfl Machi3mfl self-requested a review September 30, 2024 10:36
Machi3mfl

This comment was marked as resolved.

Sign in to view

@guidomodarelli guidomodarelli changed the base branch from 4.10.1 to 4.10.0 September 30, 2024 15:08
@guidomodarelli guidomodarelli dismissed chantal-kelm’s stale review September 30, 2024 15:08

The base branch was changed.

@guidomodarelli guidomodarelli changed the base branch from 4.10.0 to 4.10.1 September 30, 2024 15:08
@guidomodarelli guidomodarelli force-pushed the bug/25617-the-automatic-page-refresh-is-not-working branch from 59e603b to 5c71f21 Compare September 30, 2024 15:15
@guidomodarelli
Add OsdUrlStateStorage for managing app state in URL
2711749
@guidomodarelli
Add state storage to exported services
f70fea6
@guidomodarelli
Remove unused "fixedFilters" variable assignment
0415371
@guidomodarelli
Update button permissions props interface
1636dc2
@guidomodarelli
Add allowJs option to compilerOptions in tsconfig.json
b8485d4
@guidomodarelli
Update import path for 'opensearch_dashboards/public'.
2e81ed8
@guidomodarelli
Update getFileContent method signature and parameters
da700cb
@guidomodarelli
Add unit tests for clearStateFromSavedQuery function
8e0afb6
@guidomodarelli
Add constant for saved query
f7476eb
@guidomodarelli
Add test for populating state from saved query
f61b299
@guidomodarelli
Add NavigationService and createHashHistory in useSearchBar.test
159cf01
@guidomodarelli
Update OSD_URL_STATE_STORAGE_ID to APP_STATE_URL_KEY
a654b40
@guidomodarelli
Add useSavedQuery hook for handling saved queries
ee63aaf
@guidomodarelli
Add useSavedQuery hook in search-bar configuration
0c3e8cd
@guidomodarelli guidomodarelli changed the base branch from 4.10.1 to 4.10.0 September 30, 2024 15:19
Machi3mfl
Machi3mfl previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-10-01.at.4.49.10.PM.mov

@yenienserrano yenienserrano self-requested a review October 8, 2024 14:16
yenienserrano
yenienserrano previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

Screen.Recording.2024-10-08.at.4.22.32.PM.mov

@guidomodarelli guidomodarelli dismissed stale reviews from yenienserrano and Machi3mfl via bb471c0 October 8, 2024 16:59
Desvelao
Desvelao reviewed Oct 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.23% ( 4220 / 29637 )
Branches 9.26% ( 1785 / 19270 )
Functions 13.92% ( 997 / 7158 )
Lines 14.43% ( 4117 / 28522 )

@guidomodarelli
Copy link
Contributor Author

The resolution for this issue can be found in the pull request available at: #7090.

This resolution also addressed a performance concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@yenienserrano yenienserrano yenienserrano left review comments

@Machi3mfl Machi3mfl Machi3mfl left review comments

@chantal-kelm chantal-kelm Awaiting requested review from chantal-kelm

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The automatic page refresh is not working in Wazuh Dashboard in version 4.9.0
6 participants
@guidomodarelli @Machi3mfl @Desvelao @yenienserrano @chantal-kelm @asteriscos