Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Mitre overview description #7032

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Sep 30, 2024

Description

  • Mitre feature: changed its current description by Explore security alerts mapped to adversary tactics and techniques for better threat understanding.

Issues Resolved

Evidence

image

Test

  • Check mitre overview description

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Sep 30, 2024
@JuanGarriuz JuanGarriuz changed the base branch from master to 4.10.0 September 30, 2024 11:02
@JuanGarriuz JuanGarriuz changed the title Enhacement/7027 changed mitre description Changed Mitre ATT%CK overview description Sep 30, 2024
@JuanGarriuz JuanGarriuz changed the title Changed Mitre ATT%CK overview description Changed Mitre overview description Sep 30, 2024
@JuanGarriuz JuanGarriuz mentioned this pull request Sep 30, 2024
6 tasks
@JuanGarriuz JuanGarriuz linked an issue Sep 30, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Security events from the knowledge base of adversary tactics and techniques based on real-world observations',

diff --git a/plugins/main/common/wazuh-modules.ts b/plugins/main/common/wazuh-modules.ts
index 341300f65..ec327ed57 100644
--- a/plugins/main/common/wazuh-modules.ts
+++ b/plugins/main/common/wazuh-modules.ts
@@ -109,7 +109,7 @@ export const WAZUH_MODULES = {
     title: 'MITRE ATT&CK',
     appId: 'mitre-attack',
     description:
-      'Security events from the knowledge base of adversary tactics and techniques based on real-world observations',
+      'Explore security alerts mapped to adversary tactics and techniques for better threat understanding',
   },
   syscollector: {
     title: 'Inventory data',

Machi3mfl
Machi3mfl previously approved these changes Sep 30, 2024
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Before

Screenshot 2024-09-30 at 2 20 00 PM

After

Screenshot 2024-09-30 at 2 19 50 PM

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🔴

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Main plugin code coverage (Jest) test % values
Statements 14.09% ( 4177 / 29637 )
Branches 9.22% ( 1779 / 19293 )
Functions 13.74% ( 985 / 7166 )
Lines 14.28% ( 4075 / 28523 )

@asteriscos asteriscos merged commit d3f1dd5 into 4.10.0 Oct 2, 2024
5 checks passed
@asteriscos asteriscos deleted the enhacement/7027-changed-mitre-description branch October 2, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the overview page
4 participants