Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ending quotes to CDB Lists keys #7159

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Added ending quotes to CDB Lists keys #7159

merged 2 commits into from
Nov 14, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Nov 14, 2024 •
edited
Loading

Description

Added a function in CDB Lists that solve that all keys with multiple colons : should end with a quotation mark ".

Issues Resolved

Evidence

image

Test

When this PR gets code reviewed added lines are 99&100

With a real manager

Go to Server Management > CDB Lists > some list

  • Check that adding a new key with multiple : don't remove last "

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz self-assigned this Nov 14, 2024
@JuanGarriuz JuanGarriuz linked an issue Nov 14, 2024 that may be closed by this pull request
CDB list are incorrectly shown if it contains double quotes #7154
Closed
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@Tostti Tostti self-requested a review November 14, 2024 13:33
@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.74% ( 4381 / 29719 )
Branches 9.71% ( 1871 / 19262 )
Functions 14.48% ( 1039 / 7172 )
Lines 14.94% ( 4273 / 28590 )

Tostti
Tostti approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢
imagen

CR 🟢

LGTM

yenienserrano
yenienserrano approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@Tostti Tostti merged commit 676e996 into 4.10.2 Nov 14, 2024
5 checks passed
@Tostti Tostti deleted the bug/7154-add-ending-quotes-to-cdblist-keys branch November 14, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Tostti Tostti Tostti approved these changes

Assignees

@JuanGarriuz JuanGarriuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDB list are incorrectly shown if it contains double quotes
3 participants
@JuanGarriuz @Tostti @yenienserrano