Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed error message to prevent pass no strings to the wazuh logger #7167

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Fixed error message to prevent pass no strings to the wazuh logger #7167

merged 4 commits into from
Nov 21, 2024

Conversation

Machi3mfl
Copy link
Member

Description

This PR resolves some cases when the wazuh logger receives an unexpected object and cannot log correctly the error message

Closes #7165

Screenshot 2024-11-20 at 6 45 10 PM
Screen.Recording.2024-11-20.at.6.44.42.PM.mov

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos linked an issue Nov 21, 2024 that may be closed by this pull request
Server-side logger is unable to parse some errors #7165
Closed
@Machi3mfl Machi3mfl marked this pull request as ready for review November 21, 2024 16:33
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.9% ( 4436 / 29771 )
Branches 9.76% ( 1876 / 19204 )
Functions 14.66% ( 1056 / 7200 )
Lines 15.11% ( 4330 / 28643 )

asteriscos
asteriscos approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

image

image

@yenienserrano yenienserrano self-requested a review November 21, 2024 17:16
yenienserrano
yenienserrano approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🟢

Screenshots

image

image

@asteriscos asteriscos merged commit 8290673 into 4.10.0 Nov 21, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7165-server-side-logger-error-messages branch November 21, 2024 17:41
@asteriscos asteriscos mentioned this pull request Nov 25, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server-side logger is unable to parse some errors
3 participants
@Machi3mfl @asteriscos @yenienserrano