Data.vulnerability.reference field formatting fix on tables and flyouts #7177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ray) to data.vulnerability.reference(string)
|
|
yenienserrano
changed the title
|
There was a problem hiding this comment.
Legend:
⚫ 🠊 The test hasn't started yet.
🟢 🠊 All checks passed.
🟡 🠊 There is at least one expected fail or skipped test and no failures.
🔴 🠊 There is at least one failed check.
⚪ 🠊 Doesn't apply.
🔧 🠊 Request changes.
CR 🟢
TEST 🟢
Check that the field data.vulnerability.reference exists.
Navigate to Vulnerability detection > Events.
Check that the data.vulnerability.reference column shows external links.
Check that the data.vulnerability.reference field of the flyout shows external links.
Test the same in Vulnerability detection > Inventory
asteriscos
approved these changes
Nov 27, 2024
asteriscos
deleted the
fix/7176-references-to-the-vulnerability-links-are-not-rendered-correctly
branch
1 task
guidomodarelli
added a commit
that referenced
this pull request
Dec 17, 2024
…ect Wazuh API version display after upgrade
asteriscos
added a commit
that referenced
this pull request
Dec 17, 2024
* fix(get-updates): improve error handling by renaming variable for clarity and adjusting error response structure * fix(plugin-services): update WazuhCheckUpdatesServices type to include Logger for improved service management * fix(get-updates): use IAPIHost type for host management to enhance type safety and code clarity in update services * fix(get-updates): add logger for improved debugging of API status errors in update retrieval process * fix(get-updates): refactor update retrieval to include version handling and optimize status checking logic for better clarity * fix(get-updates): update test cases to handle version formatting and improve mocking for Wazuh core interactions * fix(get-updates): enhance tests by mocking last_available_patch for clearer version handling and improved stability * fix(get-updates): reorganize imports in test file for better readability and consistency with common constants and types * fix(get-updates): refactor test setup to improve mocking of saved objects and requests for more accurate updates handling * fix(get-updates): standardize api_id and version formatting in tests for consistent updates handling across all scenarios * fix(get-updates): improve error handling and add tests for undefined api_version scenarios in update fetching logic * fix(get-updates): enhance error response handling and add test for dual request failure in update fetching logic * fix(get-updates): remove unnecessary mock data from tests for clearer error handling in dual request failure scenarios * fix(get-updates): add test for handling API errors on secondary request in update retrieval logic * fix(get-updates): add test for retrieving updates when initial API version is undefined and secondary request fails * fix(get-updates): refactor test cases to use 'it' for better consistency in update retrieval tests * fix(get-updates): simplify test descriptions to improve readability in update retrieval tests * fix(get-updates): enhance test descriptions for clarity in update availability cases and error handling scenarios * fix(changelog): update entries for issue #7177 and add fix for incorrect Wazuh API version display after upgrade * fix(changelog): correct rendering entry for vulnerability reference and clarify Wazuh API version display issue after upgrade --------- Co-authored-by: Federico Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the rendering of the data.vunerability.reference in the table and flyout
Issues Resolved
Evidence
Vulnerability > Inventory
Vulnerability > Events
Test
data.vulnerability.referenceexistsdata.vulnerability.referencecolumn shows external links.data.vulnerability.referencefield of the flyout shows external links.Check List
yarn test:jest