Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed adding the same filter twice doesn't show it in the search bar. #7185

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Dec 2, 2024

Description

A timestamp has been added to handle when the same filter is added twice.

Issues Resolved

Evidence

Grabacion.2024-12-02.123459.mp4

Test

Check that adding a filter through the details flyout, deleting into the search-bar, and adding the same filter again, renders in the input of the search-bar.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz requested a review from Desvelao December 2, 2024 11:33
@JuanGarriuz JuanGarriuz marked this pull request as ready for review December 2, 2024 11:37
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use case works correctly but it would be nice to fix the following error in console:

Blocked aria-hidden on an element because its descendant retained focus. The focus must not be hidden from assistive technology users. Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which will also prevent focus. For more details, see the aria-hidden section of the WAI-ARIA specification at https://w3c.github.io/aria/#aria-hidden.
Element with focus: button
Ancestor with aria-hidden

Grabacion.de.pantalla.2024-12-02.a.la.s.10.45.32.a.m.mov

guidomodarelli
guidomodarelli previously approved these changes Dec 2, 2024
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫ 🠊 The test hasn't started yet.
🟢 🠊 All checks passed.
🟡 🠊 There is at least one expected fail or skipped test and no failures.
🔴 🠊 There is at least one failed check.
⚪ 🠊 Doesn't apply.
🔧 🠊 Request changes.

CR 🟢
TEST 🟢

Peek.2024-12-02.12-56.mp4

@JuanGarriuz
Copy link
Member Author

The use case works correctly but it would be nice to fix the following error in console:

Blocked aria-hidden on an element because its descendant retained focus. The focus must not be hidden from assistive technology users. Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which...

I can't consistently reproduce the error in the console.

image
image

@chantal-kelm chantal-kelm self-requested a review December 3, 2024 13:49
chantal-kelm
chantal-kelm previously approved these changes Dec 3, 2024
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Main plugin code coverage (Jest) test % values
Statements 15.23% ( 4534 / 29766 )
Branches 10.07% ( 1942 / 19284 )
Functions 15.16% ( 1089 / 7183 )
Lines 15.44% ( 4423 / 28635 )

@chantal-kelm chantal-kelm self-requested a review December 4, 2024 17:57
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos merged commit f9380f5 into 4.10.2 Dec 10, 2024
5 of 6 checks passed
@asteriscos asteriscos deleted the bug/7124-fixed-add-same-filter-twice-dont-show-it-in-searchbar branch December 10, 2024 11:38
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar related to Wazuh server data does not display the external filters when reapplied
4 participants