Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat AdminClient: support delete_records #136

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

wbarnha
Copy link
Owner

@wbarnha wbarnha commented Mar 8, 2024

Hey!

This PR is based on dpkp#2062
It implements delete_records for AdminClient. Thanks to @10101010 for the initial PR.

This PR contains the following improvements on that version:

  1. It fixes review comments: adds tests and removes formatting peculiarities
  2. It contains an optimization that is important to me: if multiple partitions live on the same broker, it sends one request, instead of one per partition. It is important because I use delete_records in integration tests, and this significantly improves test startup/teardown speed.
  3. It checks for errors as much as it can.

I tested it locally with 2.6.0 + py3.9, I'm assuming CI will check for everything else.
Additionally, I would like some direction from maintainers on whether it is possible/required to test this with a multi-broker setup - I couldn't find an example in the tests that uses multiple brokers.

Resolves: dpkp#2344


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for admin method: deleterecords (kip-107)
3 participants