Skip to content

Commit

Permalink
chore: silence curl output for entity import callbacks (#863)
Browse files Browse the repository at this point in the history
* chore: silence curl output for entity import callbacks

* docs: add CHANGELOG
  • Loading branch information
m90 authored Aug 14, 2024
1 parent f1ddffe commit 184cdd4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# api

## 10x.14.1 - 14 August 2024
- Silence curl output for entity import callbacks
- Make payload field in entity import fillable

## 10x.14.0 - 12 August 2024
- Add Prometheus metrics regarding Entity Import feature

Expand Down
4 changes: 2 additions & 2 deletions app/Jobs/WikiEntityImportJob.php
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,11 @@ private function constructSpec(): array
...$this->creds->marshalEnv(),
[
'name' => 'CALLBACK_ON_FAILURE',
'value' => 'curl -H "Accept: application/json" -H "Content-Type: application/json" --data \'{"wiki_entity_import":'.$this->importId.',"status":"failed"}\' -XPATCH http://api-app-backend.default.svc.cluster.local/backend/wiki/updateEntityImport'
'value' => 'curl -sS -H "Accept: application/json" -H "Content-Type: application/json" --data \'{"wiki_entity_import":'.$this->importId.',"status":"failed"}\' -XPATCH http://api-app-backend.default.svc.cluster.local/backend/wiki/updateEntityImport'
],
[
'name' => 'CALLBACK_ON_SUCCESS',
'value' => 'curl -H "Accept: application/json" -H "Content-Type: application/json" --data \'{"wiki_entity_import":'.$this->importId.',"status":"success"}\' -XPATCH http://api-app-backend.default.svc.cluster.local/backend/wiki/updateEntityImport'
'value' => 'curl -sS -H "Accept: application/json" -H "Content-Type: application/json" --data \'{"wiki_entity_import":'.$this->importId.',"status":"success"}\' -XPATCH http://api-app-backend.default.svc.cluster.local/backend/wiki/updateEntityImport'
],
],
'command' => [
Expand Down

0 comments on commit 184cdd4

Please sign in to comment.