Normalised first and lasted edited time to use revisions #854
Conversation
This commit calculates the last edited time using a similar methodology to the existing on to calculated first edited time. It uses the `allrevisions` list. This method will exclude all revisions created by the PlatformReservedUser. This means that it will erroneously ignore revisions from importing entities. Bug: T364991
tarrow
force-pushed
the
moreConversionMetricsAttempts
branch
from
bc49f40
to
93e9f05
Compare
| public function up(): void | ||
| { | ||
| WikiLifecycleEvents::all()->map->delete(); | ||
| (new UpdateWikiSiteStatsJob())->handle(); |
There was a problem hiding this comment.
Does this run synchronously and waits until all jobs for all wikis are finished or will it just dispatch a set of jobs into the queue and then move on? Asking because I would think calling handle on a job is a wee bit of an anti pattern, but maybe we just need it.
There was a problem hiding this comment.
Does this run synchronously and waits until all jobs for all wikis are finished
It does this exactly; runs them synchronously and if they fail the migration will fail. You think it would be better to just dispatch it to the queue?
There was a problem hiding this comment.
I would think that the migration runs in a transaction, and this means we have a transaction open for a very long time. But maybe that's ok.
There was a problem hiding this comment.
yeah, I would guess it be open for best part of a minute+. I've made the job dispatchable and instead dispatched it.
To paste from my local setup this of 50 Wikis from ~10s to 32ms to run the migration
database/migrations/2024_08_01_193038_remove_and_rebuild_wiki_lifecycle_events.php
Outdated
Show resolved
Hide resolved
This commit calculates the last edited time using a similar methodology to the existing on to calculated first edited time. It uses the
allrevisionslist.This method will exclude all revisions created by the PlatformReservedUser. This means that it will erroneously ignore revisions from importing entities.
Bug: T364991