Dropdown widget with multiple values: Preserve order of selected item…

…s when displaying configuration (#41)
wcm-io · Aug 23, 2024 · 212159b · 212159b
1 parent 4c38183
commit 212159b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/...bapp/app-root/clientlibs/io.wcm.caconfig.editor/js/widgets/property-dropdown.directive.js b/...bapp/app-root/clientlibs/io.wcm.caconfig.editor/js/widgets/property-dropdown.directive.js
@@ -186,9 +186,16 @@
    */
   function setValue(selectWidget, value) {
     var newValues = angular.isArray(value) ? value.map(String) : [String(value)];
-
+    // de-select all existing items
     selectWidget.items.getAll().forEach(function(item) {
-      item.selected = newValues.indexOf(item.value) > -1;
+      item.selected = false;
+    });
+    // reselect items exactly in the order stored in the data
+    newValues.forEach(value => {
+      var matchingItem = selectWidget.items.getAll().find(item => item.value == value);
+      if (matchingItem) {
+        matchingItem.selected = true;
+      }
     });
   }
 

diff --git a/changes.xml b/changes.xml
@@ -23,6 +23,12 @@
     xsi:schemaLocation="http://maven.apache.org/changes/1.0.0 http://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd">
   <body>
 
+    <release version="1.16.4" date="not released">
+      <action type="fix" dev="sseifert" issue="40">
+        Dropdown widget with multiple values: Preserve order of selected items when displaying configuration.
+      </action>
+    </release>
+
     <release version="1.16.2" date="2024-07-18">
       <action type="fix" dev="sseifert" issue="37">
         Prevent view reload when actual view parameters do not change (avoid issue e.g. with selecting item in pathbrowser first time when Unified Shell is active in AEMaaCS).