Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mandatory nodejs proxy repo to pom.xml #28

Closed
wants to merge 1 commit into from

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Mar 7, 2024

This closes #27

@stefanseifert
Copy link
Member

i try to avoid adding respositories to pom.xml, as this usually "poisons" the maven build, those repositories tend to be used for lookup for artifacts even in projects just referencing this artifact - but this repo is only required for build time of the artefact, not for build time of artifacts using it.

i created a different PR simply switching to frontend-maven-plugins which eliminates the problem in a different way: #29

@kwin
Copy link
Contributor Author

kwin commented Mar 18, 2024

Regarding lookup order please check out https://maven.apache.org/guides/mini/guide-multiple-repositories.html#repository-order (but yes, the default central repo coming from the super pom comes after a custom repo defined in the pom.xml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Build fails without tweaking the Maven settings
2 participants