-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Eliminate SonarQube warnings, "invalid" link type (#11)
and introduce "invalid" link type to mark invalid links
- Loading branch information
1 parent
c0337f7
commit 98187cb
Showing
9 changed files
with
155 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
src/main/java/io/wcm/handler/link/type/InvalidLinkType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * #%L | ||
| * wcm.io | ||
| * %% | ||
| * Copyright (C) 2024 wcm.io | ||
| * %% | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * #L% | ||
| */ | ||
| package io.wcm.handler.link.type; | ||
|
|
||
| import org.apache.sling.api.SlingHttpServletRequest; | ||
| import org.apache.sling.api.resource.Resource; | ||
| import org.apache.sling.models.annotations.Model; | ||
| import org.jetbrains.annotations.NotNull; | ||
| import org.jetbrains.annotations.Nullable; | ||
| import org.osgi.annotation.versioning.ProviderType; | ||
|
|
||
| import io.wcm.handler.link.Link; | ||
| import io.wcm.handler.link.spi.LinkType; | ||
|
|
||
| /** | ||
| * This link type is used for invalid links. It must not be registered explicitly. | ||
| */ | ||
| @Model(adaptables = { | ||
| SlingHttpServletRequest.class, Resource.class | ||
| }) | ||
| @ProviderType | ||
| public final class InvalidLinkType extends LinkType { | ||
|
|
||
| /** | ||
| * Link type ID | ||
| */ | ||
| public static final @NotNull String ID = "invalid"; | ||
|
|
||
| /** | ||
| * @return Link type ID (is stored as identifier in repository) | ||
| */ | ||
| @Override | ||
| public @NotNull String getId() { | ||
| return ID; | ||
| } | ||
|
|
||
| @Override | ||
| public @Nullable String getPrimaryLinkRefProperty() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean accepts(@NotNull String linkRef) { | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public @NotNull Link resolveLink(@NotNull Link link) { | ||
| return link; | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
src/test/java/io/wcm/handler/link/type/InvalidLinkTypeTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * #%L | ||
| * wcm.io | ||
| * %% | ||
| * Copyright (C) 2024 wcm.io | ||
| * %% | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * #L% | ||
| */ | ||
| package io.wcm.handler.link.type; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assertions.assertNull; | ||
|
|
||
| import org.apache.sling.api.adapter.Adaptable; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtendWith; | ||
|
|
||
| import io.wcm.handler.link.Link; | ||
| import io.wcm.handler.link.LinkRequest; | ||
| import io.wcm.handler.link.spi.LinkType; | ||
| import io.wcm.handler.link.testcontext.AppAemContext; | ||
| import io.wcm.sling.commons.adapter.AdaptTo; | ||
| import io.wcm.testing.mock.aem.junit5.AemContext; | ||
| import io.wcm.testing.mock.aem.junit5.AemContextExtension; | ||
|
|
||
| @ExtendWith(AemContextExtension.class) | ||
| class InvalidLinkTypeTest { | ||
|
|
||
| final AemContext context = AppAemContext.newAemContext(); | ||
|
|
||
| protected Adaptable adaptable() { | ||
| return context.request(); | ||
| } | ||
|
|
||
| @Test | ||
| void testInvalidLink() { | ||
| LinkType underTest = AdaptTo.notNull(adaptable(), InvalidLinkType.class); | ||
|
|
||
| assertEquals(InvalidLinkType.ID, underTest.getId()); | ||
| assertNull(underTest.getPrimaryLinkRefProperty()); | ||
| assertFalse(underTest.accepts(new LinkRequest(null, null, null))); | ||
|
|
||
| Link link = underTest.resolveLink(new Link(underTest, new LinkRequest(null, null, null))); | ||
| assertNotNull(link); | ||
| assertFalse(link.isValid()); | ||
| } | ||
| } |