eliminate code warnings

wcm-io · Jun 18, 2024 · fd50f24 · fd50f24
1 parent 696b263
commit fd50f24
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 19 deletions.
diff --git a/src/main/java/io/wcm/handler/link/type/MediaLinkType.java b/src/main/java/io/wcm/handler/link/type/MediaLinkType.java
@@ -97,7 +97,7 @@ public boolean hasRichTextPlugin() {
   @Override
   public boolean accepts(@NotNull String linkRef) {
     // accept as media link if the ref is inside default media subtrees
-    return MediaLinkType.isDefaultMediaContentPath(linkRef);
+    return isDefaultMediaContentPath(linkRef);
   }
 
   @SuppressWarnings("null")

diff --git a/src/main/java/io/wcm/handler/link/type/helpers/SyntheticNavigatableResource.java b/src/main/java/io/wcm/handler/link/type/helpers/SyntheticNavigatableResource.java
@@ -80,7 +80,7 @@ public Resource getParent() {
     if (parentPath == null) {
       return null;
     }
-    return SyntheticNavigatableResource.get(parentPath, resolver);
+    return get(parentPath, resolver);
   }
 
   /**

diff --git a/src/test/java/io/wcm/handler/link/impl/SeoSitemapLinkExternalizerImplTest.java b/src/test/java/io/wcm/handler/link/impl/SeoSitemapLinkExternalizerImplTest.java
@@ -56,7 +56,7 @@ class SeoSitemapLinkExternalizerImplTest {
   private Page page1;
 
   @BeforeEach
-  void setUp() throws Exception {
+  void setUp() {
 
     // simulate AEM built-in SitemapLinkExternalizer with lower service ranking
     context.registerService(SitemapLinkExternalizer.class, aemSitemapLinkExternalizer,

diff --git a/src/test/java/io/wcm/handler/link/testcontext/DummyAppTemplate.java b/src/test/java/io/wcm/handler/link/testcontext/DummyAppTemplate.java
@@ -72,11 +72,6 @@ public enum DummyAppTemplate {
     this.resourceType = resourceTypeFromTemplatePath;
   }
 
-  DummyAppTemplate(String templatePath, String resourceType) {
-    this.templatePath = templatePath;
-    this.resourceType = resourceType;
-  }
-
   /**
    * Template path
    * @return Path

diff --git a/src/test/java/io/wcm/handler/link/type/ExternalLinkTypeTest.java b/src/test/java/io/wcm/handler/link/type/ExternalLinkTypeTest.java
@@ -101,7 +101,7 @@ void testGetSyntheticLinkResource() {
   }
 
   @Test
-  void testAccepts() throws Exception {
+  void testAccepts() {
     LinkType underTest = AdaptTo.notNull(adaptable(), ExternalLinkType.class);
 
     assertTrue(underTest.accepts("http://hostname"));

diff --git a/src/test/java/io/wcm/handler/link/type/InternalCrossContextLinkTypeTest.java b/src/test/java/io/wcm/handler/link/type/InternalCrossContextLinkTypeTest.java
@@ -62,7 +62,7 @@ protected Adaptable adaptable() {
   }
 
   @BeforeEach
-  void setUp() throws Exception {
+  void setUp() {
 
     // create current page in site context
     context.currentPage(context.create().page("/content/unittest/de_test/brand/de/section/page",

diff --git a/src/test/java/io/wcm/handler/link/type/InternalLinkTypeTest.java b/src/test/java/io/wcm/handler/link/type/InternalLinkTypeTest.java
@@ -72,7 +72,7 @@ protected Adaptable adaptable() {
   }
 
   @BeforeEach
-  void setUp() throws Exception {
+  void setUp() {
 
     // create current page in site context
     context.currentPage(context.create().page("/content/unittest/de_test/brand/de/section/page",
@@ -219,7 +219,7 @@ void testSecureTargetPage() {
   }
 
   @Test
-  void testRedirectInternal() throws Exception {
+  void testRedirectInternal() {
     LinkHandler linkHandler = AdaptTo.notNull(adaptable(), LinkHandler.class);
 
     Page redirectInternalPage = context.create().page("/content/unittest/de_test/brand/de/section/redirectInternal",
@@ -240,7 +240,7 @@ void testRedirectInternal() throws Exception {
   }
 
   @Test
-  void testRedirectInternal_cqRedirectTarget() throws Exception {
+  void testRedirectInternal_cqRedirectTarget() {
     LinkHandler linkHandler = AdaptTo.notNull(adaptable(), LinkHandler.class);
 
     // redirect page using cq:redirectTarget property
@@ -282,7 +282,7 @@ void testRedirectInternal_EditMode() throws Exception {
 
   @Test
   @SuppressWarnings("null")
-  void testRedirectRedirectInternal() throws Exception {
+  void testRedirectRedirectInternal() {
     LinkHandler linkHandler = AdaptTo.notNull(adaptable(), LinkHandler.class);
 
     Page redirectInternalPage = context.create().page("/content/unittest/de_test/brand/de/section/redirectInternal",
@@ -313,7 +313,7 @@ void testRedirectRedirectInternal() throws Exception {
 
   @Test
   @SuppressWarnings("null")
-  void testRedirectExternal() throws Exception {
+  void testRedirectExternal() {
     LinkHandler linkHandler = AdaptTo.notNull(adaptable(), LinkHandler.class);
 
     Page redirectExternalPage = context.create().page("/content/unittest/de_test/brand/de/section/redirectExternal",
@@ -332,7 +332,7 @@ void testRedirectExternal() throws Exception {
   }
 
   @Test
-  void testRedirectCyclic() throws Exception {
+  void testRedirectCyclic() {
     LinkHandler linkHandler = AdaptTo.notNull(adaptable(), LinkHandler.class);
 
     String redirectInternalCyclic1Path = "/content/unittest/de_test/brand/de/section/redirectInternalCyclic1";
@@ -363,7 +363,7 @@ void testRedirectCyclic() throws Exception {
   }
 
   @Test
-  void testIntegrator() throws Exception {
+  void testIntegrator() {
     LinkHandler linkHandler = AdaptTo.notNull(adaptable(), LinkHandler.class);
 
     Page integratorPage = context.create().page("/content/unittest/de_test/brand/de/section/integrator",
@@ -382,7 +382,7 @@ void testIntegrator() throws Exception {
   }
 
   @Test
-  void testIntegrator_EditMode() throws Exception {
+  void testIntegrator_EditMode() {
     if (!(adaptable() instanceof SlingHttpServletRequest)) {
       return;
     }

diff --git a/src/test/java/io/wcm/handler/link/type/helpers/InternalLinkResolverTest.java b/src/test/java/io/wcm/handler/link/type/helpers/InternalLinkResolverTest.java
@@ -54,7 +54,7 @@ class InternalLinkResolverTest {
   private final AemContext context = AppAemContext.newAemContext();
 
   @BeforeEach
-  void setUp() throws Exception {
+  void setUp() {
 
     // create current page in site context
     context.currentPage(context.create().page("/content/unittest/de_test/brand/de/section/page",