Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Experience Fragments #22

Closed
royteeuwen opened this issue Sep 19, 2023 · 4 comments · Fixed by #23
Closed

Add support for Experience Fragments #22

royteeuwen opened this issue Sep 19, 2023 · 4 comments · Fixed by #23

Comments

@royteeuwen
Copy link
Contributor

No description provided.

royteeuwen pushed a commit to royteeuwen/io.wcm.testing.aem-mock that referenced this issue Sep 19, 2023
solves wcm-io#22: add's support for Experience Fragment classes
726701c
@royteeuwen
Copy link
Contributor Author

@stefanseifert any chance you could have a look at this :) ?

@stefanseifert
Copy link
Member

sure! (but probably after adaptTo() ...)

@prestoncrawford
Copy link

Out of curiosity, what's the "adaptTo()" functionality being worked on? I'm part of a team that's currently trying to write mocks against Experience Fragments and we're having some issues with a custom injector.

@stefanseifert stefanseifert mentioned this issue Oct 12, 2023
Merged
@stefanseifert
Copy link
Member

@prestoncrawford the PR from #23 comes with an adapter factory implementation, so it's possible to adapt AEM page objects to ExperienceFragment or ExperienceFragmentVariation interfaces

stefanseifert added a commit that referenced this issue Oct 13, 2023
@royteeuwen @stefanseifert
solves #22: add's support for Experience Fragment classes (#23)
4119165 
Co-authored-by: Roy Teeuwen <[email protected]>
Co-authored-by: Stefan Seifert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

solves #22: add's support for Experience Fragment classes royteeuwen/io.wcm.testing.aem-mock
3 participants
@prestoncrawford @royteeuwen @stefanseifert