Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solves #22: add's support for Experience Fragment classes #23

Merged
merged 7 commits into from
Oct 13, 2023

Conversation

royteeuwen
Copy link
Contributor

@royteeuwen royteeuwen commented Sep 19, 2023

Fixes #22

@stefanseifert
Copy link
Member

@royteeuwen thanks for the contribution!

i've done some cosmetic touches to the code to format it according to our guidelines and decreased the visibility of the classes, as they are only accessed via adaptTo() and not directly.

please have a look at the sonarcloud analysis and check if you can increase the coverage a bit to comply with the quality gate, and have a look at the two code smells:
https://github.com/wcm-io/io.wcm.testing.aem-mock/pull/23/checks?check_run_id=17642665908

@stefanseifert stefanseifert merged commit 4119165 into wcm-io:develop Oct 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Experience Fragments
2 participants