Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always filter out secondary alignments, always remove soft clipped bases #30

Merged
merged 1 commit into from
May 18, 2024

Conversation

fellen31
Copy link
Contributor

@fellen31 fellen31 commented May 7, 2024

If secondary alignments are filtered out without --ubam they should also be filtered out with --ubam.

Unaligned reads should never have any soft clipped bases, and since softclipped_bases(&read) should always be 0 for these, it can always be removed.

Potentially closes #29

@fellen31 fellen31 marked this pull request as ready for review May 7, 2024 09:39
@wdecoster
Copy link
Owner

Okay, I think you are right :)

@wdecoster wdecoster merged commit 0eaeb3a into wdecoster:master May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should --ubam really include secondary alignments?
2 participants