-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
消息模板匹配器 #91
Merged
Merged
消息模板匹配器 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new Rule `PatternRule` (cherry picked from commit 44d6c88) do not modify OnMessage method
RikaCelery
commented
Oct 9, 2024
RikaCelery
commented
Oct 10, 2024
fumiama
requested changes
Oct 11, 2024
chained pattern builder remove useless structs rename function As... => Get...
parse tests Getxxx tests SetOptional tests
…pattern-matcher # Conflicts: # pattern_test.go
(cherry picked from commit 5a945cc)
RikaCelery
commented
Oct 12, 2024
fumiama
requested changes
Oct 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还需修复lint。
拉取最新后即可见。 |
Co-authored-by: 源文雨 <[email protected]>
remove Valid field (replaced with value!=nil)
Co-authored-by: 源文雨 <[email protected]>
要不要加个Any匹配任意消息 |
也行 |
其实有一个和你这个实现的比较类似的东西 |
写的真好看🥳 |
fumiama
requested changes
Oct 13, 2024
fumiama
requested changes
Oct 14, 2024
better code structure
refactor: remove useless args make lint happy
fumiama
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
旨在提供一种更好的消息匹配方式
避免因可能的onebot扩展导致正则匹配失效