Merge pull request #5 from cblk/master

feat(tonic): use shouldBind for default binding hook

tonic/handler.go

@@ -84,21 +84,11 @@ func Handler(h interface{}, status int, options ...func(*Route)) gin.HandlerFunc
 				handleError(c, bindError)
 				return
 			}
-			// Bind query-parameters.
-			if err := bind(c, input, QueryTag, extractQuery); err != nil {
-				handleError(c, err)
-				return
-			}
 			// Bind path arguments.
 			if err := bind(c, input, PathTag, extractPath); err != nil {
 				handleError(c, err)
 				return
 			}
-			// Bind headers.
-			if err := bind(c, input, HeaderTag, extractHeader); err != nil {
-				handleError(c, err)
-				return
-			}
 			// validating query and path inputs if they have a validate tag
 			initValidator()
 			args = append(args, input)

tonic/tonic.go

@@ -13,7 +13,6 @@ import (
 	"time"
 
 	"github.com/gin-gonic/gin"
-	"github.com/gin-gonic/gin/binding"
 	validator "gopkg.in/go-playground/validator.v9"
 )
 
@@ -93,10 +92,7 @@ var DefaultBindingHook BindHook = DefaultBindingHookMaxBodyBytes(DefaultMaxBodyB
 func DefaultBindingHookMaxBodyBytes(maxBodyBytes int64) BindHook {
 	return func(c *gin.Context, i interface{}) error {
 		c.Request.Body = http.MaxBytesReader(c.Writer, c.Request.Body, maxBodyBytes)
-		if c.Request.ContentLength == 0 || c.Request.Method == http.MethodGet {
-			return nil
-		}
-		if err := c.ShouldBindWith(i, binding.JSON); err != nil && err != io.EOF {
+		if err := c.ShouldBind(i); err != nil && err != io.EOF {
 			return err
 		}
 		return nil