-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove author-provided <datalist> from <select>
The author-provided datalist imposes a lot of complexity, and now that we aren't requiring it for HTML parser changes, it doesn't provide any additional capabilities. This patch also makes the UA popover actually have the popover attribute and makes it a <div> instead of a <datalist>. No code or concepts have "datalist" in them anymore except ::select-fallback-datalist because that is likely to get a different standards-approved name soon. This was discussed here: openui/open-ui#1082 This patch also moves a bunch of tests from external/wpt to wpt_internal because we aren't allowed to use test_driver in reftests in external/wpt, and I was using datalist.showPicker() in a bunch of reftests which we can't do anymore because the popover is now a pseudo-element which can only be opened via select.showPicker() which requires user activation, and in order to get user activation, we have to run test_driver.bless(). Change-Id: Ib8230bc5eec214f09147ae806490df729f1e4412
- Loading branch information
1 parent
2a7b7ed
commit 32b248f
Showing
16 changed files
with
27 additions
and
434 deletions.
There are no files selected for viewing
86 changes: 0 additions & 86 deletions
86
html/semantics/forms/the-select-element/stylable-select/resources/stylable-select-styles.css
This file was deleted.
Oops, something went wrong.
31 changes: 0 additions & 31 deletions
31
...lect-element/stylable-select/select-child-button-and-datalist-invalidation.tentative.html
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
...antics/forms/the-select-element/stylable-select/select-child-button-and-datalist-ref.html
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
.../forms/the-select-element/stylable-select/select-child-button-and-datalist.tentative.html
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 0 additions & 75 deletions
75
.../forms/the-select-element/stylable-select/select-datalist-popover-behavior.tentative.html
This file was deleted.
Oops, something went wrong.
16 changes: 0 additions & 16 deletions
16
html/semantics/forms/the-select-element/stylable-select/select-icon-color-ref.html
This file was deleted.
Oops, something went wrong.
17 changes: 0 additions & 17 deletions
17
html/semantics/forms/the-select-element/stylable-select/select-icon-color.tentative.html
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.