Prepare to enable HDR media capabilities by default. #42856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 31, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4989038
branch
3 times, most recently
from
1580091 to
1e5143f
Compare
I2S approved here: https://groups.google.com/a/chromium.org/g/blink-dev/c/0neM-5GDn8I/m/ymH32sDDAgAJ This cleans up an unnecessary feature flag and implements the rest of the feature per the current spec. Adds a test for mismatched color space information. w3c/media-capabilities#152 covers how we should reject mismatched color parameters, though a PR to add it to the spec hasn't yet been made. Safari has implemented this behavior though, so copy it. Bug: 1048045 Change-Id: I4fee62361c697922bb041724f4e4ac8c8e9d5c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989038 Reviewed-by: Johannes Kron <[email protected]> Commit-Queue: Dale Curtis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1217958}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4989038
branch
from
1e5143f to
1baa716
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I2S approved here:
https://groups.google.com/a/chromium.org/g/blink-dev/c/0neM-5GDn8I/m/ymH32sDDAgAJ
This cleans up an unnecessary feature flag and implements
the rest of the feature per the current spec. Adds a test
for mismatched color space information.
w3c/media-capabilities#152 covers
how we should reject mismatched color parameters, though a
PR to add it to the spec hasn't yet been made. Safari has
implemented this behavior though, so copy it.
Bug: 1048045
Change-Id: I4fee62361c697922bb041724f4e4ac8c8e9d5c2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4989038
Reviewed-by: Johannes Kron <[email protected]>
Commit-Queue: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1217958}