Revert subtests removal for selection-direction.tentative.html #48267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sefeng211
approved these changes
Sep 19, 2024
|
No problem, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we re-add the subtests removed at 15c5ae8. See discussion at #48258 for the reasoning why this test is valuable in WPT.
We add it as a separate new test file since it is not testing for behavior inside shadow DOM and the standardization of its behavior is separate to whether Selection.direction is specced/shipped. Hence, it should remain a tentative test until issue w3c/selection-api#177 is resolved.