[BUGFIX] Guard ViewHelper argument with null-coalesce operator

This changes guards the `extension` argument of the ViewHelper with the null-coalesce operator and a string-cast to avoid a TypeError with TYPO3 v12 which expectes a string for the `ExtensionManagementUtility::isLoaded()`method.
web-vision · Jul 21, 2023 · cbb5fb6 · cbb5fb6
1 parent 87c071b
commit cbb5fb6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Classes/ViewHelpers/Be/ExtensionActiveViewHelper.php b/Classes/ViewHelpers/Be/ExtensionActiveViewHelper.php
@@ -33,7 +33,7 @@ public function initializeArguments(): void
 
     public static function verdict(array $arguments, RenderingContextInterface $renderingContext): bool
     {
-        if (ExtensionManagementUtility::isLoaded($arguments['extension'])) {
+        if (ExtensionManagementUtility::isLoaded((string)($arguments['extension'] ?? ''))) {
             return true;
         }
         return false;

diff --git a/Tests/Functional/ViewHelpers/ExtensionActiveViewHelperTest.php b/Tests/Functional/ViewHelpers/ExtensionActiveViewHelperTest.php
@@ -53,7 +53,7 @@ public static function renderDataProvider(): \Generator
             [],
             'elseArgument',
         ];
-        
+
         yield 'extension provided as undefined fluid variable placeholder, await else' => [
             '<deepl:be.extensionActive extension="{someUndefinedVariable}" then="thenArgument" else="elseArgument" />',
             [],
-Original file line number
+Diff line change
@@ Expand Up / @@ -53,7 +53,7 @@ public static function renderDataProvider(): \Generator @@
                 [],
                 'elseArgument',
             ];
             yield 'extension provided as undefined fluid variable placeholder, await else' => [
                 '<deepl:be.extensionActive extension="{someUndefinedVariable}" then="thenArgument" else="elseArgument" />',
                 [],
@@ Expand Down @@