[!!!][TASK] Extract glossary related functionality into new addon webvision/deepltranslate-glossary
#405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calien666
force-pushed
the
extract-glossary
branch
2 times, most recently
from
4bb816c to
242d741
Compare
sbuerk
changed the title
webvision/deepltranslate-glossary
sbuerk
requested changes
Dec 17, 2024
calien666
force-pushed
the
extract-glossary
branch
2 times, most recently
from
ec04cb0 to
176b8ad
Compare
…vision/deepltranslate-glossary In favour of external glossary support the complete glossary functionality is removed.
calien666
force-pushed
the
extract-glossary
branch
2 times, most recently
from
d52bc68 to
80f8ad6
Compare
calien666
force-pushed
the
extract-glossary
branch
from
80f8ad6 to
55f7748
Compare
Getting rid of x-classing is the goal and with v12 an event is provided manipulating the header of the RecordListController. In favour of using this event instead of x-classing the original class, an event listener is added generating the dropdown and adding top-most of the recordlist. This has effects on positioning of the translation dropdown, which now is rendered before the core dropdown instead of next to it.
Getting rid of x-classing is the goal and with v12 an event is provided manipulating the header of the RecordListController. In favour of using this event instead of x-classing the original class, an event listener is added generating the dropdown and adding top-most of the recordlist. This has effects on positioning of the translation dropdown, which now is rendered before the core dropdown instead of next to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.