[TASK] Ensure working PageLayout localization modal for v13 #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TASK] Ensure working PageLayout localization modal for v13
TYPO3 changes in a lot of areas including the backend JavaScript
and CSS definition where the most part are taken as internal and
not as public API. This can change in even in LTS versions, but
most likely in newer major versions.
With TYPO3 v13 context aware lightning (light/dark mode) has been
introduces which is a hard thing for icons in regards of readability.
To ensure that the
DeepL Translate
part within this localizationmodel works for TYPO3 v13 this change ...
(compiled within a TYPO3 13.4 monorepo !) as documentation while also
providing the compiled JavaScript in the public resources folder with
a core version suffix while keeping the compiled v12 variant.
Configuration/JavaScriptModules.php
to override theTYPO3 core
localization
file with the custom file based for thecurrent used core version.
and using the
currentColor
defined by the context to suite in bothmodes (light and dark).
overriden localization JavaScript code to ensure that icon labels
breaks correctly. Workaround for a core bug in this area. [1][2]
localization JavaScript file to include the svg - otherwise the
theme based context color would not take effect, which works
around another known TYPO3 core bug.
to allow or deny the next step for the deepltranslate modes has been
streamlined as a side change. Mainly v13, v12 only partly due to
general overhaul in TYPO3 v13.
no longer closeable (v12 + v13).
The build system for the TypeScript -> JavaScript must be revised
in the next year (2025) to be capable of building against multiple
core versions. The v13 has been compiled and extracted directly in a
TYPO3 Core Development instance using the monorepo on branch 13.4.
[1] https://forge.typo3.org/issues/105853
[2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/87576
TYPO3 v12
TYPO3 v13 lightmode
TYPO3 v13 darkmode
TYPO3 v13 darkmode - missing configuration alert