chore: prepare for the first release #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krzysu
commented
Oct 31, 2024
•
krzysu
commented
- remove experimental methods as likely not supported and no time right now to test them
- fix watchAsset method and retested with all wallets
- improve docs and prepare for the first release
krzysu
commented
Oct 31, 2024
| @@ -172,7 +118,7 @@ export class WalletRpcPlugin extends Web3PluginBase<WalletRpcApi> { | |||
| public async watchAsset(param: WatchAssetRequest): Promise<boolean> { | |||
| return this.requestManager.send({ | |||
| method: 'wallet_watchAsset', | |||
| params: [param], | |||
| params: param, | |||
There was a problem hiding this comment.
this was the issue with watchAsset
krzysu
requested review from
danforbes,
avkos,
Muhammad-Altabba,
luu-alex and
jdevcs
avkos
approved these changes
Oct 31, 2024
danforbes
approved these changes
Oct 31, 2024
luu-alex
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.