Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update http quicknode rpc-provider #7102

Merged
merged 13 commits into from
Jul 10, 2024
Merged

update http quicknode rpc-provider #7102

merged 13 commits into from
Jul 10, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Jun 13, 2024

#7068 Creates a specific error for exceeding rate limits

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Jun 13, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 630.09 kB → 630.57 kB (+487 B) +0.08%
Changeset
File Δ Size
../web3-rpc-providers/lib/commonjs/errors.js 🆕 +1.14 kB 0 B → 1.14 kB
../web3-rpc-providers/lib/commonjs/web3_provider.js 📈 +479 B (+10.04%) 4.66 kB → 5.13 kB
../web3-providers-http/lib/commonjs/index.js 📈 +34 B (+0.76%) 4.37 kB → 4.41 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 610.8 kB → 611.27 kB (+487 B) +0.08%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 5bb783b Previous: bfe2769 Ratio
processingTx 8866 ops/sec (±4.01%) 8959 ops/sec (±4.44%) 1.01
processingContractDeploy 39764 ops/sec (±6.62%) 39629 ops/sec (±8.47%) 1.00
processingContractMethodSend 15913 ops/sec (±7.49%) 16647 ops/sec (±9.83%) 1.05
processingContractMethodCall 27884 ops/sec (±7.85%) 28056 ops/sec (±6.60%) 1.01
abiEncode 44486 ops/sec (±6.96%) 43700 ops/sec (±8.36%) 0.98
abiDecode 30720 ops/sec (±8.51%) 30625 ops/sec (±8.11%) 1.00
sign 1527 ops/sec (±3.48%) 1567 ops/sec (±0.76%) 1.03
verify 371 ops/sec (±0.46%) 376 ops/sec (±0.39%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (bfe2769) to head (5bb783b).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7102   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         215      215           
  Lines        8334     8335    +1     
  Branches     2296     2296           
=======================================
+ Hits         7897     7898    +1     
  Misses        437      437           
Flag Coverage Δ
UnitTests 94.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@luu-alex luu-alex requested a review from jdevcs June 19, 2024 13:12
@luu-alex luu-alex changed the title update http update http quicknode rpc-provider Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants