-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): external-provider #7119
base: 4.x
Are you sure you want to change the base?
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: c24010d | Previous: 4f8e8cc | Ratio |
---|---|---|---|
processingTx |
21813 ops/sec (±7.95% ) |
21886 ops/sec (±6.09% ) |
1.00 |
processingContractDeploy |
39868 ops/sec (±7.20% ) |
38750 ops/sec (±9.06% ) |
0.97 |
processingContractMethodSend |
15840 ops/sec (±7.05% ) |
15198 ops/sec (±8.03% ) |
0.96 |
processingContractMethodCall |
27633 ops/sec (±6.69% ) |
26542 ops/sec (±7.32% ) |
0.96 |
abiEncode |
42330 ops/sec (±7.69% ) |
40956 ops/sec (±7.46% ) |
0.97 |
abiDecode |
29030 ops/sec (±8.08% ) |
29461 ops/sec (±6.44% ) |
1.01 |
sign |
1476 ops/sec (±3.30% ) |
1499 ops/sec (±3.97% ) |
1.02 |
verify |
360 ops/sec (±0.45% ) |
355 ops/sec (±0.76% ) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7119 +/- ##
==========================================
+ Coverage 94.45% 94.47% +0.01%
==========================================
Files 215 215
Lines 8391 8411 +20
Branches 2313 2321 +8
==========================================
+ Hits 7926 7946 +20
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some next PR when RPC providers package is added in libdocs, I think its link and one line intro also needs to be in https://docs.web3js.org/#packages--plugins section.
this PR looks good, Thanks @danforbes |
@danforbes @jdevcs you can use the code WEB3JS and user will get 20% off for 2 months when they switch to a paid RPC provider with Quick Nodes. |
03c89d6
to
d08c738
Compare
b608114
to
cf066d2
Compare
cf066d2
to
181a86d
Compare
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Still active |
Add documentation for external providers.
Closes #7115