update typescript version to 5 #7272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7272 +/- ##
==========================================
+ Coverage 94.51% 94.54% +0.02%
==========================================
Files 218 218
Lines 8557 8637 +80
Branches 2364 2364
==========================================
+ Hits 8088 8166 +78
- Misses 469 471 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 32ad76e | Previous: 56d4aec | Ratio |
|---|---|---|---|
processingTx |
21300 ops/sec (±7.49%) |
21333 ops/sec (±6.28%) |
1.00 |
processingContractDeploy |
38260 ops/sec (±8.07%) |
37350 ops/sec (±9.12%) |
0.98 |
processingContractMethodSend |
15576 ops/sec (±7.37%) |
15425 ops/sec (±8.46%) |
0.99 |
processingContractMethodCall |
27068 ops/sec (±6.53%) |
27828 ops/sec (±7.27%) |
1.03 |
abiEncode |
41259 ops/sec (±6.71%) |
42616 ops/sec (±7.22%) |
1.03 |
abiDecode |
27751 ops/sec (±8.81%) |
29566 ops/sec (±9.87%) |
1.07 |
sign |
1530 ops/sec (±0.67%) |
1505 ops/sec (±3.30%) |
0.98 |
verify |
362 ops/sec (±2.98%) |
365 ops/sec (±0.58%) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Muhammad-Altabba
changed the title
Muhammad-Altabba
requested review from
avkos,
jdevcs and
luu-alex
as code owners
jdevcs
reviewed
Sep 23, 2024
avkos
requested changes
Sep 23, 2024
avkos
approved these changes
Sep 24, 2024
jdevcs
reviewed
Nov 4, 2024
There was a problem hiding this comment.
@Muhammad-Altabba before merging into 4.x, pls merge latest 4.x in to this branch and update configs as there is a new package as well : https://github.com/web3/web3.js/tree/4.x/packages/web3-account-abstraction thanks
danforbes
approved these changes
Nov 5, 2024
|
As discussed dev release from this PR needs to be tested with a plugin. |
krzysu
reviewed
Nov 14, 2024
krzysu
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.