7203 - Alchemy rpc provider #7296
Conversation
| let host = ''; | ||
| let token = ''; | ||
|
|
||
| switch (network) { |
There was a problem hiding this comment.
MRLab12
requested review from
avkos,
luu-alex and
Muhammad-Altabba
as code owners
| [Network.POLYGON_AMOY]: 'polygon-amoy.g.alchemy.com', | ||
| [Network.OPTIMISM_MAINNET]: 'opt-mainnet.g.alchemy.com', | ||
| [Network.OPTIMISM_SEPOLIA]: 'opt-sepolia.g.alchemy.com', | ||
| }; |
There was a problem hiding this comment.
It would be great to add all Alchemy platforms if they are compatible with web3js.
There was a problem hiding this comment.
Is this screenshot from web.js? Wondering if this is an accurate list of the chains to support with Alchemy.
There was a problem hiding this comment.
@avkos Made some changes, not sure if all the chains I added are to be supported but lmk.
| web3.provider?.disconnect(); | ||
| } | ||
| }); | ||
| it(`AlchemyProvider should work with ${transport} transport and ${network} network`, async () => { |
There was a problem hiding this comment.
After adding all platforms it will be a different array of networks. so it will be better to have separate const networksAlchemy and separate test networksAlchemy.forEach
MRLab12
force-pushed
the
alchemy-rpc-provider
branch
2 times, most recently
from
5103d29
to
b17f49d
Compare
Co-authored-by: Junaid <[email protected]>
MRLab12
force-pushed
the
alchemy-rpc-provider
branch
from
7aefd55
to
2982118
Compare
MRLab12
force-pushed
the
alchemy-rpc-provider
branch
from
97135dc
to
2982118
Compare
# Conflicts: # packages/web3-rpc-providers/src/types.ts # packages/web3/test/integration/web3RPCProviders.test.ts
There was a problem hiding this comment.
Many thanks @MRLab12 for your contribution,
It seems great now. I think, once other team members approve, we can merge this MR.
|
I'm trying to run integration tests locally but having issues. Looking at the test errors here, most likely a missing Alchemy key is the issue. Can someone point me to how this should be set up? |
Description
I have opened this Draft PR to make sure I did the correct changes and get some feedback since this is my first contribution here.This PR adds an Alchemy provider in
web3-rpc-providers. I matched the design of the Quicknode provider.For testing, I wasn't sure if a test for this provider should actually try to make a request. Should we consider mocking? I want to learn more about how testing is done in web3.js.
Fixes #7203
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.