Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/add all test donator #101

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

danielcdz
Copy link
Contributor

@danielcdz danielcdz commented Sep 27, 2024

Pull Request

Changes Description

  • Bump snforge_std version to 0.27.0
    After the bump, I fixed all errors caused by the upgrade of the version. This involves tests for the Fund and Donator contracts.
  • Create new tests for the DonatorManager contract
    • New tests to cover all the methods in the contract
    • I have added two new methods to the contract to read the owner and the donator class hash from the storage.

Current output

  • Tests:
    image

Time spent breakdown

  • 4 days
    • The effort involves a lot of research about how to implement the tests in the best way using snforge_std, after the research I found that the best was to update the version of this package to take advantage of the cheat codes available to set the caller address before the deployment of the contract.

Comments

  • Bump snforge_std version to 0.27.0.
    • Fix and update current tests and code to match the new version.

@EmmanuelAR EmmanuelAR self-assigned this Sep 28, 2024
@EmmanuelAR EmmanuelAR self-requested a review September 28, 2024 20:26
@EmmanuelAR EmmanuelAR removed their assignment Sep 28, 2024
@danielcdz danielcdz marked this pull request as ready for review September 30, 2024 04:03
@danielcdz
Copy link
Contributor Author

@EmmanuelAR this is ready for review! 🫡

@EmmanuelAR
Copy link
Collaborator

i will review today asap @danielcdz thnks sr

@EmmanuelAR EmmanuelAR merged commit 1d5e059 into web3wagers:dev Sep 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] Add all tests for DonatorManager Contract
2 participants