Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add users funds page #107

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

wugalde19
Copy link
Contributor

Pull Request

Changes description

  1. Add myfunds page
  2. Create FundCard component
  3. Create UserFunds component
  4. Allow Button UI component to receive className for custom classes

TODOs added

// TODO: Implement new fund action
// TODO: Implement funds fetching using 'userAddress'
// TODO: Implement fund deletion based on a unique id or receive the fund object and delete it

Current output

Screenshot 2024-09-29 at 10 16 19 PM Screenshot 2024-09-29 at 10 22 07 PM Screenshot 2024-09-29 at 10 17 06 PM Screenshot 2024-09-29 at 10 21 47 PM

Time spent breakdown

1.5 - 2 hours

Comments

@wugalde19 wugalde19 changed the title Feat/add users funds page Feat: Add users funds page Sep 30, 2024
@adrianvrj adrianvrj linked an issue Sep 30, 2024 that may be closed by this pull request
@adrianvrj adrianvrj self-requested a review September 30, 2024 15:12
Copy link
Member

@adrianvrj adrianvrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@adrianvrj
Copy link
Member

@wugalde19 it seems like something is missing, please take a look at the error in the pipeline, you should add some static params or something like that in order to make production deploy work

@wugalde19 wugalde19 force-pushed the feat/add-users-funds-page branch from 3575e5e to 090fdfe Compare October 1, 2024 03:15
@wugalde19
Copy link
Contributor Author

@adrianvrj I've fixed the issue
I tried the build locally and it seems to be working fine
Please let me know if you want me to apply some other change(s)
image

@adrianvrj
Copy link
Member

@wugalde19 great work homie, merged!

@adrianvrj adrianvrj merged commit faaaa09 into web3wagers:dev Oct 1, 2024
5 checks passed
@wugalde19
Copy link
Contributor Author

@wugalde19 great work homie, merged!

Thanks @adrianvrj 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Add Users funds page
2 participants