Fix: move increment id because the first fund was with id 0. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EmmanuelAR what is the reason for this change? it is known in programming that ids normally start with 0, as in any array the first position is taken as 0 |
|
I get it now, 0 would denote NULL if we are talking about table objects, great catch g, appreciate the change |
adrianvrj
approved these changes
Oct 2, 2024
|
I see like in order, if we want to show the funds will be weird to see a id in 0, another point is that i see like a sql tables, the first register will ! |
|
@EmmanuelAR is this bug present in the other manager? |
No, for the donator manager we use the donator address as key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: move increment id because the first fund was with id 0.