refactor: change data types to handle ERC20 tokens #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelAR
approved these changes
Oct 11, 2024
adrianvrj
reviewed
Oct 11, 2024
| @@ -4,5 +4,6 @@ | |||
| pub mod FundConstants { | |||
| pub const UP_VOTES_NEEDED: u32 = 100; | |||
| pub const INITIAL_UP_VOTES: u32 = 0; | |||
| pub const INITIAL_GOAL: u64 = 0; | |||
| pub const INITIAL_GOAL: u256 = 0; | |||
| pub const STRK_TOKEN_ADDRESS: felt252 = 0x04718f5a0fc34cc1af16a1cdee98ffb20c31f5cd61d6ab07201858f4287c938d; | |||
There was a problem hiding this comment.
@EmmanuelAR did you planned to add a new constant file for managing token addresses?
There was a problem hiding this comment.
merge, i will create a new file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes #129
Changes description
Modify the data types across smart contracts and constants to
u256to handle ERC20 token transactionsComments
Necessary refactor to start working on #120 and #121 properly.