Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test withdraw method functionality #159

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

manlikeHB
Copy link
Contributor

@manlikeHB manlikeHB commented Oct 25, 2024

Pull Request

Changes description

Describe what your changes will do and any TODOs there might be in the future related to the issue you are closing.

Current output

Screenshot 2024-10-28 at 12 25 10 PM

Time spent breakdown

Give a breakdown on the time you used to solve the issue you are closing.

Comments

Any other details you might want to share.

@manlikeHB
Copy link
Contributor Author

@adrianvrj @EmmanuelAR An erc20 token address needs to be passed to the withdraw function to be able to call balance_of and transfer function on it.

@EmmanuelAR EmmanuelAR self-requested a review October 25, 2024 17:18
@manlikeHB manlikeHB marked this pull request as ready for review October 28, 2024 11:28
@EmmanuelAR
Copy link
Collaborator

Thks for the update, we will review some of the prs that was post first and let u know any change @manlikeHB

@bitfalt bitfalt mentioned this pull request Oct 29, 2024
5 tasks
@EmmanuelAR
Copy link
Collaborator

hey @manlikeHB we merge some new changes, could you please refresh the test please?

Copy link
Collaborator

@EmmanuelAR EmmanuelAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmanuelAR EmmanuelAR merged commit b7a708b into web3wagers:dev Nov 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] Test withdraw method functionality
2 participants